Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BQ Tables: ctor, scalar property definitions #1021

Merged
merged 8 commits into from
Jul 30, 2015
Merged

BQ Tables: ctor, scalar property definitions #1021

merged 8 commits into from
Jul 30, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 28, 2015

Support missing for:

  • schema (next PR)
  • externalDataConfiguration (experimental feature, deferring for now).

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 28, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2015
dhermes
dhermes reviewed Jul 28, 2015
View reviewed changes
gcloud/bigquery/_helpers.py

import pytz

_EPOCH = datetime.datetime(1970, 1, 1, tzinfo=pytz.utc)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Jul 29, 2015
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Jul 29, 2015

@dhermes any remaining issues?

dhermes
dhermes reviewed Jul 29, 2015
View reviewed changes
gcloud/bigquery/_helpers.py
_EPOCH = datetime.datetime(1970, 1, 1, tzinfo=pytz.utc)


def _millis(when):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jul 29, 2015

Remaining issues (summarized here for future me):

  • Consistent epoch handling
  • Exception in view_query.setter
  • "definiing" mis-spelling

@tseaver
Copy link
Contributor Author

tseaver commented Jul 29, 2015

I think the last three commits address those issues.

@dhermes dhermes mentioned this pull request Jul 30, 2015
Closed
@dhermes
Copy link
Contributor

dhermes commented Jul 30, 2015

LGTM

tseaver added a commit that referenced this pull request Jul 30, 2015
@tseaver
Merge pull request #1021 from tseaver/bigquery-table_ctor_properties
2928bfc 
BQ Tables:  ctor, scalar property definitions
@tseaver tseaver merged commit 2928bfc into googleapis:master Jul 30, 2015
@tseaver tseaver deleted the bigquery-table_ctor_properties branch July 30, 2015 02:42
@dhermes dhermes mentioned this pull request Aug 12, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot