Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISCUSSION: Do we need ACL lazy loading? #752

Closed
dhermes opened this issue Mar 23, 2015 · 0 comments · Fixed by #771
Closed

DISCUSSION: Do we need ACL lazy loading? #752

dhermes opened this issue Mar 23, 2015 · 0 comments · Fixed by #771
Assignees
@dhermes
Labels
api: storage Issues related to the Cloud Storage API.
Milestone
Storage Stable

Comments

@dhermes
Copy link
Contributor

dhermes commented Mar 23, 2015

Is there a good reason for the lazy loading behavior, e.g.

        if self._acl is None:
            self._acl = ObjectACL(self)

This doesn't make any requests and just initializes a very lightweight object.

I move to just create these in the constructor.
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 23, 2015
@dhermes dhermes added this to the Storage Stable milestone Mar 23, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Mar 28, 2015
@dhermes
Ditching lazy loading for ACLs attached to Blob/Bucket.
935c612 
Fixes googleapis#752.
@dhermes dhermes mentioned this issue Mar 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
Storage Stable
Development

Successfully merging a pull request may close this issue.

Ditching lazy loading for ACLs attached to Blob/Bucket. dhermes/google-cloud-python
1 participant
@dhermes