Error when downloading blobs with storage v1.1.0

[theacodes]

See build log: https://www.google.com/url?q=https%3A%2F%2Ftravis-ci.org%2FGoogleCloudPlatform%2Fpython-docs-samples%2Fbuilds%2F226935178%23L786&sa=D&sntz=1&usg=AFQjCNG3mWBi07AXjvj70yKUdQ0pI4hJNw

[dhermes]

So this is kind of a bug, kind of not a bug, but some code needs to change.

TLDR; My vote for a fix: make the Blob.download_to_filename file timestamp update optional, dependent on self.updated is not None

---

The old implementation did something somewhat silly. It called reload on the instance if the media_link wasn't present, essentially forcing users to incur two round trips.

I "turned off" this "feature" in my fix (and @tseaver asked why / if that was OK during code review). However, that revealed a (IMO long-standing) bug elsewhere in the code:

mtime = time.mktime(self.updated.timetuple())

i.e. the Blob.download_to_filename assumes the updated property is populated, which assumes reload has been called (or the _properties have been populated in some other way).

[theacodes]

TLDR; My vote for a fix: make the Blob.download_to_filename file timestamp update optional, dependent on self.updated is not None

Fine with me.

[danigosa]

Same issue here, is there any workaround or sticking to 1.0.0 'til the fix? All our tests failed miserably because of the upgrade.

[dhermes]

@danigosa I'll send out a fix today and we can push a 1.1.1 release. SGTY @jonparrott and @lukesneeringer?

[theacodes]

Yes