Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should language document_from_text() etc. be a reference to the Document class #2183

Closed
dhermes opened this issue Aug 24, 2016 · 1 comment
Closed
Assignees
Labels
api: language Issues related to the Cloud Natural Language API API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@dhermes
Copy link
Contributor

dhermes commented Aug 24, 2016

See https://github.com/GoogleCloudPlatform/gcloud-python/pull/2062/files/d36ad4db94666450786d4f667aea0607ff2113cb#r76032786

The question is whether we should have Client.document_from_foo methods or just have Client.document be a reference to the class Document and then use Client.document.from_foo.

This amounts to swapping _ for . (i.e. no less typing) and makes a "proper noun" like Document be referenced as an "improper noun" as a property, which is not a win IMO

@dhermes dhermes changed the title Should language document_from_text() etc. by a reference to the Document class Should language document_from_text() etc. be a reference to the Document class Aug 24, 2016
@danoscarmike danoscarmike added api: language Issues related to the Cloud Natural Language API API. and removed natural-language labels Feb 21, 2017
@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 19, 2017
@lukesneeringer
Copy link
Contributor

Hello!
We have done a less-than-great job of dealing with issues in this repository. Sorry about that. :-(

In this case, we have released an entirely different version of google-cloud-language, which is very likely to have solved this issue, so I am going and closing language-related issues en masse to try and regain sanity and ability to tackle things.

Please upgrade to the newest version of google-cloud-language and use LanguageServiceClient. Note that this will require a code change. If your issue persists, feel free to reopen. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

4 participants