Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt split repo: _python-api-common-protos_ #10891

Closed
vchudnov-g opened this issue Apr 4, 2023 · 2 comments
Closed

Adopt split repo: _python-api-common-protos_ #10891

vchudnov-g opened this issue Apr 4, 2023 · 2 comments
Assignees
@parthea
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:pr:none Split repo to be migrated has no pending PRs migration:samples:none Split repo to be migrated here has no samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 4, 2023 •
edited
Loading

Migrate the split-repo https://github.com/googleapis/python-api-common-protos to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:none Split repo to be migrated here has no samples migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:testing:unit Split repo to be migrated here has unit tests migration:issues:open Split repo to be migrated here has open issues when last checked labels Apr 4, 2023
@parthea
Copy link
Contributor

parthea commented Apr 5, 2023

Marking this issue as blocked because the repository does not have code generated using bazel rules. The generate_protos nox session is run in owlbot.py which uses protoc directly.

@parthea parthea added the status: blocked Resolving the issue is dependent on other work. label Apr 5, 2023
@parthea parthea self-assigned this Apr 5, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-api-common-protos Adopt split repo: _python-api-common-protos_ Apr 6, 2023
@vchudnov-g vchudnov-g added migration:pr:none Split repo to be migrated has no pending PRs migration:workaround:protoplus Split repo needs BUILD rule configuration to use proto-plus labels Apr 6, 2023
@parthea parthea removed their assignment Apr 6, 2023
@vchudnov-g vchudnov-g added migration:pr:pending Split repo to be migrated has pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs labels May 5, 2023
@parthea
Copy link
Contributor

parthea commented Nov 3, 2023

Closing as the migration is now complete and we won't be migrating these remaining repositories. We can re-open this issue if we want to onboard this repository to the monorepo.

@parthea parthea closed this as completed Nov 3, 2023
@parthea parthea reopened this Dec 20, 2024
@parthea parthea self-assigned this Dec 20, 2024
@parthea parthea added migration:workaround:none Split repo to be migrated here has no manual workarounds migration:pr:none Split repo to be migrated has no pending PRs migration:issues:none Split repo to be migrated here had no open issues when last checked and removed status: blocked Resolving the issue is dependent on other work. migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:issues:open Split repo to be migrated here has open issues when last checked migration:pr:pending Split repo to be migrated has pending PRs migration:workaround:protoplus Split repo needs BUILD rule configuration to use proto-plus labels Dec 20, 2024
This was referenced Dec 20, 2024
Merged
Merged
parthea added a commit that referenced this issue Jan 10, 2025
@parthea
chore(migration): Migrate code from googleapis/python-api-common-prot…
c74b5b5 
…os into packages/googleapis-common-protos (#13381)

See #10891. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@parthea parthea added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) labels Jan 10, 2025
@parthea parthea added migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Jan 10, 2025
@parthea parthea closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:pr:none Split repo to be migrated has no pending PRs migration:samples:none Split repo to be migrated here has no samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g