Skip to content

Commit

Permalink
Drop overlooked docs / system test usage of 'Table.rename'.
Browse files Browse the repository at this point in the history
Addresses:
#1908 (comment)
  • Loading branch information
tseaver committed Jun 26, 2016
1 parent 9a2d313 commit f5b1719
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 30 deletions.
11 changes: 0 additions & 11 deletions docs/bigtable-table-api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,6 @@ Make a `DeleteTable`_ API request with
table.delete()
Rename an existing Table
------------------------

Though the `RenameTable`_ API request is listed in the service
definition, requests to that method return::

BigtableTableService.RenameTable is not yet implemented

We have implemented :meth:`rename() <gcloud.bigtable.table.Table.rename>`
but it will not work unless the backend supports the method.

List Column Families in a Table
-------------------------------

Expand Down
19 changes: 0 additions & 19 deletions system_tests/bigtable.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,25 +232,6 @@ def test_create_table(self):
sorted_tables = sorted(tables, key=name_attr)
self.assertEqual(sorted_tables, expected_tables)

def test_rename_table(self):
from grpc.beta import interfaces
from grpc.framework.interfaces.face import face

temp_table_id = 'foo-bar-baz-table'
temp_table = Config.CLUSTER.table(temp_table_id)
temp_table.create()
self.tables_to_delete.append(temp_table)

with self.assertRaises(face.LocalError) as exc_manager:
temp_table.rename(temp_table_id + '-alt')
exc_caught = exc_manager.exception
self.assertNotEqual(exc_caught, None)
self.assertEqual(exc_caught.code,
interfaces.StatusCode.UNIMPLEMENTED)
self.assertEqual(
exc_caught.details,
'BigtableTableService.RenameTable is not yet implemented')

def test_create_column_family(self):
temp_table_id = 'foo-bar-baz-table'
temp_table = Config.CLUSTER.table(temp_table_id)
Expand Down

0 comments on commit f5b1719

Please sign in to comment.