Actually use the progress_bar_type argument in QueryJob.to_dataframe()

googleapis · Mar 29, 2019 · e0dff69 · e0dff69
1 parent 8942439
commit e0dff69
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/bigquery/google/cloud/bigquery/job.py b/bigquery/google/cloud/bigquery/job.py
@@ -2857,7 +2857,9 @@ def to_dataframe(self, bqstorage_client=None, dtypes=None, progress_bar_type=Non
             ValueError: If the `pandas` library cannot be imported.
         """
         return self.result().to_dataframe(
-            bqstorage_client=bqstorage_client, dtypes=dtypes
+            bqstorage_client=bqstorage_client,
+            dtypes=dtypes,
+            progress_bar_type=progress_bar_type,
         )
 
     def __iter__(self):

diff --git a/bigquery/google/cloud/bigquery/table.py b/bigquery/google/cloud/bigquery/table.py
@@ -1422,9 +1422,7 @@ def _get_progress_bar(self, progress_bar_type):
                     desc=description, total=self.total_rows, unit=unit
                 )
             elif progress_bar_type == "tqdm_gui":
-                return tqdm.tqdm_gui(
-                    desc=description, total=self.total_rows, unit=unit
-                )
+                return tqdm.tqdm_gui(desc=description, total=self.total_rows, unit=unit)
         except (KeyError, TypeError):
             # Protect ourselves from any tqdm errors. In case of
             # unexpected tqdm behavior, just fall back to showing
@@ -1515,14 +1513,16 @@ class _EmptyRowIterator(object):
     pages = ()
     total_rows = 0
 
-    def to_dataframe(self, bqstorage_client=None, dtypes=None):
+    def to_dataframe(self, bqstorage_client=None, dtypes=None, progress_bar_type=None):
         """Create an empty dataframe.
 
         Args:
             bqstorage_client (Any):
                 Ignored. Added for compatibility with RowIterator.
             dtypes (Any):
                 Ignored. Added for compatibility with RowIterator.
+            progress_bar_type (Any):
+                Ignored. Added for compatibility with RowIterator.
 
         Returns:
             pandas.DataFrame: