Skip to content

Commit

Permalink
Merge pull request #1131 from tseaver/bigquery-system_tests-unique_da…
Browse files Browse the repository at this point in the history
…taset

Use a unique dataset ID for each run of BQ system tests.
  • Loading branch information
tseaver committed Sep 10, 2015
2 parents 61abd0c + fa6a32a commit 219fe75
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions system_tests/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

_helpers.PROJECT = TESTS_PROJECT
CLIENT = bigquery.Client()
DATASET_NAME = 'system_tests_%012d' % (1000 * time.time(),)


class TestBigQuery(unittest2.TestCase):
Expand All @@ -36,7 +37,6 @@ def tearDown(self):
doomed.delete()

def test_create_dataset(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand All @@ -45,7 +45,6 @@ def test_create_dataset(self):
self.assertEqual(dataset.name, DATASET_NAME)

def test_reload_dataset(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
dataset.friendly_name = 'Friendly'
dataset.description = 'Description'
Expand All @@ -57,7 +56,6 @@ def test_reload_dataset(self):
self.assertEqual(other.description, 'Description')

def test_patch_dataset(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand All @@ -70,7 +68,6 @@ def test_patch_dataset(self):
self.assertEqual(dataset.description, 'Description')

def test_update_dataset(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand Down Expand Up @@ -106,7 +103,6 @@ def test_list_datasets(self):
self.assertEqual(len(created), len(datasets_to_create))

def test_create_table(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand All @@ -124,7 +120,6 @@ def test_create_table(self):
self.assertTrue(table._dataset is dataset)

def test_list_tables(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand All @@ -151,7 +146,6 @@ def test_list_tables(self):
self.assertEqual(len(created), len(tables_to_create))

def test_patch_table(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand All @@ -172,7 +166,6 @@ def test_patch_table(self):
self.assertEqual(table.description, 'Description')

def test_update_table(self):
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand Down Expand Up @@ -205,7 +198,6 @@ def test_load_table_then_dump_table(self):
('Bhettye Rhubble', 27),
]
ROW_IDS = range(len(ROWS))
DATASET_NAME = 'system_tests'
dataset = CLIENT.dataset(DATASET_NAME)
self.assertFalse(dataset.exists())
dataset.create()
Expand Down Expand Up @@ -252,7 +244,6 @@ def test_load_table_from_storage_then_dump_table(self):
('Wylma Phlyntstone', 29),
('Bhettye Rhubble', 27),
]
DATASET_NAME = 'system_tests'
TABLE_NAME = 'test_table'

s_client = StorageClient()
Expand Down

0 comments on commit 219fe75

Please sign in to comment.