Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using row_set in rows() method. #44

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Using row_set in rows() method. #44

merged 5 commits into from
Oct 4, 2018

Conversation

sumit-ql
Copy link
Contributor

  1. Updated rows() method to use row_set, removed rows_keys_filter_helper.
  2. Updated unit tests as per changes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2018
@sumit-ql
Copy link
Contributor Author

@tseaver Please review this PR.

@tseaver
Copy link
Contributor

tseaver commented Oct 3, 2018

@sduskis Should we merge this PR before #41? If so, I would need to adjust the changelog there.

@sduskis
Copy link

sduskis commented Oct 3, 2018

@tseaver, I would definitely like to get this in before #41.

@sduskis sduskis merged commit 5e7edce into googleapis:master Oct 4, 2018
This was referenced Oct 4, 2018
Closed
Merged
@sumit-ql sumit-ql deleted the update_rows_method_to_use_row_set branch October 18, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumit-ql @tseaver @sduskis @googlebot