Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests timezone issues #713

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Fix tests timezone issues #713

merged 1 commit into from
Oct 25, 2017

Conversation

vam-google
Copy link
Contributor

Also enforce UTC timezone for GrpcTrait::formatTimestampForApi().

@vam-google
Fix tests timezone-related issues.
1ade83c 
Enforce UTC timezone for GrpcTrait::formatTimestampForApi().
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2017
dwsupplee
dwsupplee approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this!

@dwsupplee dwsupplee merged commit 6b741ea into googleapis:master Oct 25, 2017
@jdpedrie jdpedrie mentioned this pull request Nov 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vam-google @jdpedrie @dwsupplee @googlebot