Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates dependencies to more accurately reflect the repo #691

Merged

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Sep 27, 2017

Exchanges ext-grpc for google/cloud-logging

@bshaffer bshaffer requested a review from tmatsuo September 27, 2017 23:29
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 27, 2017
@googleapis googleapis deleted a comment from googlebot Sep 27, 2017
@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2017
@bshaffer bshaffer requested a review from jdpedrie September 28, 2017 22:14
@bshaffer
Copy link
Contributor Author

bshaffer commented Sep 28, 2017

Some context:

  1. Stackdriver Logging is capable of reporting errors to Stackdriver Error Reporting using the jsonPayload field
  2. The Stackdriver Logging API parses this field and when certain attributes exist (such as reportLocation.functionName, serviceContext.module, and serviceContext.version), the log is reported as an error.
  3. We have a handwritten Logging client and a gRPC-only Error reporting client. Additionally, @tmatsuo has added some support for Bootstrapping the PHP Exception/Error/Shutdown handlers and using the Logging client. All of these work specifically with the Batch Runner and the PHP runtime.

Moving forward with the current state of things, I've made samples (and documentation) to use the Logging client for error reporting and use some of the Bootstrapping for registering the error handlers (see this PR). However, error reporting is something most users will just want to have work with as little effort as possible, and we are not there yet. Hopefully we'll be there before this library goes beta.

Some things I want to have by then:

  1. a one-liner for registering the error handler
  2. a one-liner for reporting an error
  3. samples which use google/cloud-error-reporting instead of google/cloud
  4. documentation for integrating the error handler into wordpress, laravel, symfony, and possibly others.
  5. documentation for integrating into GCE and GKE

This PR is an effort to move in that direction, so that users don't need gRPC in order to log exceptions.

@bshaffer
Copy link
Contributor Author

We missed 0.40 on this, but I would love to get this merged for the next release.

@jdpedrie
Copy link
Contributor

cc @tmatsuo

@dwsupplee dwsupplee merged commit 5c36bca into googleapis:master Oct 18, 2017
@bshaffer bshaffer deleted the better-dependencies-for-error_reporting branch October 18, 2017 22:10
@jdpedrie jdpedrie mentioned this pull request Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants