feat: add support for ARCHIVE storage class

[jdpedrie]

Closes #2425

cc @tritone for review.

[codecov]

Codecov Report

Merging #2428 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2428      +/-   ##
============================================
+ Coverage     92.47%   92.55%   +0.07%     
- Complexity     4477     4504      +27     
============================================
  Files           312      312              
  Lines         13416    13496      +80     
============================================
+ Hits          12407    12491      +84     
+ Misses         1009     1005       -4

Impacted Files	Coverage Δ	Complexity Δ
Storage/src/StorageClient.php	100% <ø> (ø)	31 <0> (ø)	⬇️
Storage/src/Lifecycle.php	70% <ø> (ø)	20 <0> (ø)	⬇️
Storage/src/Bucket.php	97.18% <ø> (ø)	70 <0> (ø)	⬇️
Firestore/src/Query.php	99.2% <0%> (-0.01%)	86% <0%> (ø)
Translate/src/Connection/ConnectionInterface.php
Translate/src/TranslateClient.php	100% <0%> (ø)	23% <0%> (?)
Translate/src/Connection/Rest.php	100% <0%> (+100%)	4% <0%> (+4%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca739c4...0b03b09. Read the comment docs.

[tritone]

Test looks good, had a comment about the documentation piece. Also, please wait to merge this as the feature is still behind a flag (I will give a heads up when it's ready in a couple weeks).

[tritone]

It would be good to re-sort this list as follows: STANDARD, NEARLINE, COLDLINE, ARCHIVE. Then note that MULTI_REGIONAL, REGIONAL, DURABLE_REDUCED_AVAILABILITY are legacy (ie not recommended for new implementations). Should look similar to the comment here in the ruby client library, plus the addition of ARCHIVE: https://github.com/googleapis/google-cloud-ruby/blob/master/google-cloud-storage/lib/google/cloud/storage/bucket.rb#L358 . You can also add a link to the docs about storage classes here (if you don't think it's too much info for this context): https://cloud.google.com/storage/docs/storage-classes

Same thing for StorageClient.php

[jdpedrie]

Done!

[tritone]

Looks good to me; will give approval once the feature is no longer behind a flag. Also needs approval from a repo owner. Thanks!

[tritone]

We are clear to merge this now with a plan to release the change between 1/2 and 1/8. It looks like there are two remaining things now to be resolved:

• @dwsupplee , we need repo owner approval from you on this PR.
• Looks like the code coverage check is also currently blocking the merge. @jdpedrie could you look into that?

Let me know if either of you see any issue with this timeline.

[jdpedrie]

@tritone just rebased this, should fix the coverage check.

[dwsupplee]

Looks good! Just some small notes.

[jdpedrie]

Thanks @dwsupplee. Went back to including the double-quotes, since I think that's more in line with the general formatting we've preferred til now.