Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Firestore cleanup and fixes #1982

Merged
merged 1 commit into from
May 30, 2019
Merged

fix: Firestore cleanup and fixes #1982

merged 1 commit into from
May 30, 2019

Conversation

jdpedrie
Copy link
Contributor

Fixed some minor mistakes and one potential bug where user-provided options were not passed to a write as expected.

@jdpedrie jdpedrie added the api: firestore Issues related to the Firestore API. label May 30, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 30, 2019
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@51e5281). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1982   +/-   ##
=========================================
  Coverage          ?   92.56%           
  Complexity        ?     4371           
=========================================
  Files             ?      303           
  Lines             ?    12989           
  Branches          ?        0           
=========================================
  Hits              ?    12023           
  Misses            ?      966           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Firestore/src/QuerySnapshot.php 100% <ø> (ø) 5 <0> (?)
Firestore/src/Query.php 99.19% <ø> (ø) 85 <0> (?)
Firestore/src/Connection/Grpc.php 100% <ø> (ø) 12 <0> (?)
Firestore/src/SnapshotTrait.php 100% <ø> (ø) 26 <0> (?)
Firestore/src/PathTrait.php 100% <100%> (ø) 31 <0> (?)
Firestore/src/WriteBatch.php 100% <100%> (ø) 128 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e5281...d6566ec. Read the comment docs.

@dwsupplee dwsupplee merged commit cbbcf6e into googleapis:master May 30, 2019
@jdpedrie jdpedrie mentioned this pull request Jun 3, 2019
@jdpedrie jdpedrie deleted the firestore-cleanup branch September 12, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants