Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Update Compute Metadata Reader #1974

Merged
merged 1 commit into from
Jun 12, 2019
Merged

feat(core): Update Compute Metadata Reader #1974

merged 1 commit into from
Jun 12, 2019

Conversation

jdpedrie
Copy link
Contributor

Fixes #359.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2019
@codecov
Copy link

codecov bot commented May 27, 2019 •
edited
Loading

Codecov Report

Merging #1974 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1974      +/-   ##
============================================
+ Coverage     91.65%   91.66%   +0.01%     
- Complexity     4419     4423       +4     
============================================
  Files           305      306       +1     
  Lines         13109    13125      +16     
============================================
+ Hits          12015    12031      +16     
  Misses         1094     1094
Impacted Files Coverage Δ Complexity Δ
...src/Compute/Metadata/Readers/HttpHandlerReader.php 100% <100%> (ø) 3 <3> (?)
Core/src/Compute/Metadata/Readers/StreamReader.php 100% <100%> (ø) 2 <0> (ø) ⬇️
Core/src/Compute/Metadata.php 100% <100%> (ø) 10 <2> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a84771...93f1e18. Read the comment docs.

@jdpedrie jdpedrie changed the title Update Compute Metadata Reader feat(core): Update Compute Metadata Reader May 30, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@jdpedrie jdpedrie requested a review from dwsupplee June 12, 2019 18:06
@dwsupplee dwsupplee merged commit b3f5c95 into googleapis:master Jun 12, 2019
@jdpedrie jdpedrie deleted the compute-guzzle branch June 12, 2019 19:29
@jdpedrie jdpedrie mentioned this pull request Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsupplee dwsupplee dwsupplee approved these changes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute should use guzzle by default
4 participants
@jdpedrie @dwsupplee @googlebot @yoshi-automation