Adds an option to return raw results from BigQuery #1872
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1872 +/- ##
============================================
+ Coverage 91.59% 91.65% +0.05%
- Complexity 4412 4421 +9
============================================
Files 305 305
Lines 13100 13110 +10
============================================
+ Hits 11999 12016 +17
+ Misses 1101 1094 -7
Continue to review full report at Codecov.
|
| @@ -146,6 +146,9 @@ public function __construct( | |||
| * **Defaults to** `10000` milliseconds (10 seconds). | |||
| * @type int $maxRetries The number of times to poll the Job status, | |||
| * until the job is complete. By default, will poll indefinitely. | |||
| * @type bool $returnRawResults Returns the raw data types returned from | |||
There was a problem hiding this comment.
A common way to execute queries is through BigQueryClient::runQuery which does a little magic to hide the interaction with the QueryResults class. Could we please make sure to also surface configuration option there?
There was a problem hiding this comment.
Hey Dave. I started looking into this and was hoping you could help me come with an example? In the snippet below I used the runQuery command, get a result set back, and then pass the returnRawResults option while retrieving rows.
$queryJobConfig = $bigQuery->query($query);
$queryResults = $bigQuery->runQuery($queryJobConfig);
$rows = $queryResults->rows(['returnRawResults' => true]);
foreach ($rows as $row) {
print_r($row);
}
Does this look like what you had in mind?
There was a problem hiding this comment.
Close, I was thinking like this:
$queryResults = $bigQuery->runQuery($queryJobConfig, [
'returnRawResults' => true // make sure this is surfaced in the `runQuery` documentation
]);
foreach ($queryResults as $row) {
// ....
}There was a problem hiding this comment.
@dwsupplee - The option is being passed via the runQuery result now 👍
dwsupplee
added
needs work
danielgsims
removed
the
needs work
See #1287