Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Tasks V2 to GA #1861

Merged
merged 3 commits into from
May 2, 2019
Merged

Move Tasks V2 to GA #1861

merged 3 commits into from
May 2, 2019

Conversation

dwsupplee
Copy link
Contributor

No description provided.

@dwsupplee dwsupplee added the api: cloudtasks Issues related to the Cloud Tasks API. label May 2, 2019
@dwsupplee dwsupplee requested a review from jdpedrie May 2, 2019 05:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@codecov
Copy link

codecov bot commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #1861 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1861   +/-   ##
=========================================
  Coverage     91.59%   91.59%           
  Complexity     4412     4412           
=========================================
  Files           305      305           
  Lines         13100    13100           
=========================================
  Hits          11999    11999           
  Misses         1101     1101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5fb1e...a4d5897. Read the comment docs.

jdpedrie
jdpedrie approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@jdpedrie jdpedrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one question.

README.md
$client->deleteQueue($queueName);
```

#### Removal of pull queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to maintain this notice indefinitely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so. We could probably give it another month or so and then remove it. WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me.

@jdpedrie jdpedrie merged commit 850e9a5 into googleapis:master May 2, 2019
@jdpedrie jdpedrie mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

Assignees
No one assigned
Labels
api: cloudtasks Issues related to the Cloud Tasks API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwsupplee @jdpedrie @googlebot