Lazily instantiate admin and operations clients #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1852 +/- ##
============================================
+ Coverage 91.58% 91.59% +0.01%
- Complexity 4408 4412 +4
============================================
Files 305 305
Lines 13103 13100 -3
============================================
- Hits 12000 11999 -1
+ Misses 1103 1101 -2
Continue to review full report at Codecov.
|
dwsupplee
approved these changes
Apr 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1851 by only instantiating the Instance and Database admin clients when they are first used. The data client is still created upfront as it's the only one used in the course of the common usage.