Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction configuration for single-use transactions #1844

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Fix transaction configuration for single-use transactions #1844

merged 1 commit into from
Apr 24, 2019

Conversation

jdpedrie
Copy link
Contributor

Database::execute() runs operations within a single-use transaction, but due to the order in which the transaction was configured, single-use configuration options (maxStaleness and minReadTimestamp) were not available to that method.

Fixes #1830.

@jdpedrie jdpedrie added the api: spanner Issues related to the Spanner API. label Apr 23, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e66cb6d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1844   +/-   ##
=========================================
  Coverage          ?   91.58%           
  Complexity        ?     4408           
=========================================
  Files             ?      305           
  Lines             ?    13103           
  Branches          ?        0           
=========================================
  Hits              ?    12000           
  Misses            ?     1103           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
Spanner/src/TransactionConfigurationTrait.php 100% <100%> (ø) 24 <0> (?)
Spanner/src/Database.php 100% <100%> (ø) 74 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66cb6d...c825374. Read the comment docs.

@jdpedrie jdpedrie added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@dwsupplee dwsupplee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2019
@jdpedrie jdpedrie added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2019
@dwsupplee dwsupplee merged commit 8be1132 into googleapis:master Apr 24, 2019
@jdpedrie jdpedrie mentioned this pull request May 2, 2019
@jdpedrie jdpedrie deleted the spanner-single-use-fix branch September 12, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spanner] What is "singleUse" key in transaction options?
4 participants