Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system tests: search: delete documents individually #784

Merged
merged 1 commit into from
Aug 6, 2015
Merged

system tests: search: delete documents individually #784

merged 1 commit into from
Aug 6, 2015

Conversation

stephenplusplus
Copy link
Contributor

RE: #775 (comment)

The Search API doesn't allow indexes to be deleted. Instead, you can delete all of the documents within them. That's what we were doing previously, but as the amount of created Documents grows, it's taking an excessive amount of time to fetch, then iteratively delete each one that exists.

This PR changes the tests to create/delete a document, instead of letting the before/after hooks handle it the old way.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2015
@stephenplusplus stephenplusplus mentioned this pull request Aug 6, 2015
Closed
@jgeewax
Copy link
Contributor

jgeewax commented Aug 6, 2015 via email

@stephenplusplus
Copy link
Contributor Author

Yep, thanks. Will fix that in the first post.

callmehiphop
callmehiphop reviewed Aug 6, 2015
View reviewed changes
system-test/search.js
@@ -67,12 +56,8 @@ describe('Search', function() {
var INDEX_NAME = generateIndexName();
var index = search.index(INDEX_NAME);

before(function(done) {
deleteAllDocuments(done);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop added a commit that referenced this pull request Aug 6, 2015
@callmehiphop
Merge pull request #784 from stephenplusplus/spp--search-tests
eaf753e 
system tests: search: delete documents individually
@callmehiphop callmehiphop merged commit eaf753e into googleapis:master Aug 6, 2015
@callmehiphop
Copy link
Contributor

Travis will be so happy! (I hope!)

@quartzmo
Copy link
Member

quartzmo commented Oct 5, 2015

@stephenplusplus We are trying to follow your work on Search, as we're about to start on it for the Ruby lib. Do you think you could create a search label and add it to issues like this one?

@stephenplusplus
Copy link
Contributor Author

@quartzmo sure, I found a few: https://github.com/GoogleCloudPlatform/gcloud-node/issues?q=label%3Asearch+is%3Aclosed I don't think we've had that many. Let me know if any questions come up.

@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@gcf-owl-bot
fix: regenerated protos JS and TS definitions (#784)
986f27b 
samples: pull in latest typeless bot, clean up some comments

Source-Link: https://github.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@release-please
chore(main): release 4.3.0 (#778)
2512765 
🤖 I have created a release *beep* *boop*
---


## [4.3.0](https://github.com/googleapis/nodejs-dlp/compare/v4.2.0...v4.3.0) (2023-01-06)


### Features

* ExcludeByHotword added as an ExclusionRule type, NEW_ZEALAND added as a LocationCategory value ([5b54b2e](https://github.com/googleapis/nodejs-dlp/commit/5b54b2e9c63acee3022089d9fb94d8b1907c1eb2))


### Bug Fixes

* Deprecate extra field to avoid confusion ([#777](https://github.com/googleapis/nodejs-dlp/issues/777)) ([f6a7ebd](https://github.com/googleapis/nodejs-dlp/commit/f6a7ebde9f78440600ac178a568e3fe79ccfadc2))
* **deps:** Use google-gax v3.5.2 ([#781](https://github.com/googleapis/nodejs-dlp/issues/781)) ([3601ed8](https://github.com/googleapis/nodejs-dlp/commit/3601ed84fa97958ca52bdc8d5620317f1a4a1de5))
* Regenerated protos JS and TS definitions ([#784](https://github.com/googleapis/nodejs-dlp/issues/784)) ([fa109f0](https://github.com/googleapis/nodejs-dlp/commit/fa109f05c3a29473a330e96b20e89480fb89496e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@munkhuushmgl
fix: mocha tests (#784)
f334bf0
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@gcf-owl-bot
fix: failing tests for LRO check methods (#784)
b81427e 
* fix: failing tests for LRO check methods

Updated gapic-generator-typescript to v2.1.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 387841814

Source-Link: googleapis/googleapis@f973532

Source-Link: googleapis/googleapis-gen@acb489d

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@release-please
chore: release 4.5.6 (#785)
7b17f0a 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.5.6](https://github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02)


### Bug Fixes

* failing tests for LRO check methods ([#784](https://github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@gcf-owl-bot
fix: failing tests for LRO check methods (#784)
390ed67 
* fix: failing tests for LRO check methods

Updated gapic-generator-typescript to v2.1.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 387841814

Source-Link: googleapis/googleapis@f973532

Source-Link: googleapis/googleapis-gen@acb489d

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@release-please
chore: release 4.5.6 (#785)
1f1ebbd 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.5.6](https://github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02)


### Bug Fixes

* failing tests for LRO check methods ([#784](https://github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenplusplus @jgeewax @callmehiphop @quartzmo @googlebot