Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery: implemented streamrouter in dataset #739

Merged
merged 1 commit into from
Jul 24, 2015
Merged

bigquery: implemented streamrouter in dataset #739

merged 1 commit into from
Jul 24, 2015

Conversation

callmehiphop
Copy link
Contributor

This will add stream support to Dataset#getTables()

@stephenplusplus I had to add autoPaginate: false to a couple of tests to stop them from failing. Was that the right thing to do?

  • Add stream router to Dataset
  • Update documentation to show stream examples
  • Mock stream router in unit tests
  • Add system tests

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2015
@callmehiphop callmehiphop changed the title bigtable: implemented streamrouter in dataset bigquery: implemented streamrouter in dataset Jul 24, 2015
@callmehiphop callmehiphop added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigquery Issues related to the BigQuery API. don't merge and removed don't merge labels Jul 24, 2015
stephenplusplus
stephenplusplus reviewed Jul 24, 2015
View reviewed changes
lib/bigquery/dataset.js
* //-
* dataset.getTables()
* .on('error', console.error)
* .on('data', function(table) {})

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor

LGTM. Feel free to merge it in after my tiny comment

@callmehiphop
bigquery: implemented streamrouter in dataset
59c7b9f 
updated unit and system tests

added a bit more documentation
callmehiphop added a commit that referenced this pull request Jul 24, 2015
@callmehiphop
Merge pull request #739 from callmehiphop/gettables-streamrouter
648e6d5 
bigquery: implemented streamrouter in dataset
@callmehiphop callmehiphop merged commit 648e6d5 into googleapis:master Jul 24, 2015
@callmehiphop callmehiphop deleted the gettables-streamrouter branch July 24, 2015 18:40
sofisl pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
chore(deps): update dependency jsdoc-fresh to v2 (#739)
b893d0c 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc-fresh](https://github.com/googleapis/jsdoc-fresh) | [`^1.1.0` -> `^2.0.0`](https://renovatebot.com/diffs/npm/jsdoc-fresh/1.1.1/2.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/compatibility-slim/1.1.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc-fresh/2.0.0/confidence-slim/1.1.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/jsdoc-fresh</summary>

### [`v2.0.0`](https://github.com/googleapis/jsdoc-fresh/blob/HEAD/CHANGELOG.md#&#8203;200-httpsgithubcomgoogleapisjsdoc-freshcomparev111v200-2022-05-18)

[Compare Source](https://github.com/googleapis/jsdoc-fresh/compare/v1.1.1...v2.0.0)

##### ⚠ BREAKING CHANGES

-   update library to use Node 12 ([#&#8203;108](https://github.com/googleapis/jsdoc-fresh/issues/108))

##### Build System

-   update library to use Node 12 ([#&#8203;108](https://github.com/googleapis/jsdoc-fresh/issues/108)) ([e61c223](https://github.com/googleapis/jsdoc-fresh/commit/e61c2238db8900e339e5fe7fb8aea09642290182))

##### [1.1.1](https://github.com/googleapis/jsdoc-fresh/compare/v1.1.0...v1.1.1) (2021-08-11)

##### Bug Fixes

-   **build:** migrate to using main branch ([#&#8203;83](https://www.github.com/googleapis/jsdoc-fresh/issues/83)) ([9474adb](https://github.com/googleapis/jsdoc-fresh/commit/9474adbf0d559d319ff207397ba2be6b557999ac))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-compute).
@sofisl sofisl mentioned this pull request Nov 17, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callmehiphop @stephenplusplus @googlebot