-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce auto-generated Gapic client for monitoring API #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, thank you! 👍
@@ -0,0 +1,201 @@ | |||
Apache License |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
{ | ||
"url": "https://github.com/googleapis/googleapis", | ||
"name": "@google-cloud/monitoring", | ||
"version": "0.7.1", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -0,0 +1,21 @@ | |||
{ | |||
"url": "https://github.com/googleapis/googleapis", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
"description": "Stackdriver Monitoring library for Node.js", | ||
"main": "src/index.js", | ||
"files": [ | ||
"src" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -0,0 +1,45 @@ | |||
Stackdriver Monitoring API for Node.js |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
"name": "@google-cloud/monitoring", | ||
"version": "0.7.1", | ||
"author": "Google Inc.", | ||
"description": "Stackdriver Monitoring library for Node.js", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
"engines": { | ||
"node": ">=0.12.0" | ||
} | ||
} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
"google-proto-files": "^0.8.2", | ||
"google-gax": "^0.7.0", | ||
"extend": "^3.0.0", | ||
"lodash.union": "^4.6.0" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thanks for the review! This should be ready for another pass. |
Thanks! There are some linting errors: https://travis-ci.org/GoogleCloudPlatform/google-cloud-node/jobs/164763097 -- is it possible to correct these, or do we need to disable linting on these files? // @jmuk |
Looks to be a bug on our toolchain. I'll make some quick hand edits to this to match the bugfix. |
A quick win might be not naming the anonymous function set on the prototype: -Service.prototype.method = function method() {
+Service.prototype.method = function() { |
Actually, the linting errors (aside from the trailing space that I added) require a little more thought than I had previously anticipated. @jmuk thoughts on how this should be fixed? |
@landrito: The lint happens on the variable names only, so function (project, metricDescriptorPath) {
return METRIC_DESCRIPTOR_PATH_PATH_TEMPLATE.render({
project: project,
metric_descriptor_path: metricDescriptorPath
});
} would be okay with jscs (it doesn't look great though). Changing the field name for |
I see. I'll make the changes for the variable names and anonymous functions to toolkit and regenerate then. Thanks for looking into this. |
@stephenplusplus. Regenerated! PTAL. |
Changes Unknown when pulling 9efe9b1 on landrito:monitoring into * on GoogleCloudPlatform:master*. |
Thanks! @callmehiphop it looks like there's a error with parsing the docs, can you take a look? https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-node/build/1.0.281/job/4k6cbwvjoh2mg4a4#L723 |
Ping. |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
I added a test and more docs around how this is used. Since @callmehiphop I'm getting tripped up trying to get |
Changes Unknown when pulling 33bdc64 on landrito:monitoring into * on GoogleCloudPlatform:master*. |
Sorry, I missed this! Looks like the Monitoring title is missing from the overview config file. |
33bdc64
to
e11d2e5
Compare
Added it there, but new error:
Feel free to check out this PR and get it working. You can push to |
The service folders within docs/json are not generated. For whatever reason we keep them checked into git via .gitkeep files. It looks like you just need to make the monitoring/master folder. |
Woo, that did it! Ironically, this is the exact reason we have |
Awesome! As a side note, maybe we should look into generating the folders? I'm not sure I really see a need to keep them checked into git. |
Sure, generating them is fine. |
c053805
to
48e7cec
Compare
No description provided.