Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cluster links and option handling #1420

Merged
merged 2 commits into from
Jul 12, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added test for options
  • Loading branch information
callmehiphop committed Jul 12, 2016
commit ba265a8bc7d5d092380956426ead8c24469d6f3f
18 changes: 18 additions & 0 deletions test/bigtable/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,24 @@ describe('Bigtable', function() {
fakeUtil.normalizeArguments = normalizeArguments;
});

it('should leave the original options unaltered', function() {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

var fakeOptions = {
a: 'a',
b: 'b',
c: 'c',
zone: 'zone'
};

var bigtable = new Bigtable(fakeOptions);
var options = bigtable.calledWith_[1];

for (var option in fakeOptions) {
assert.strictEqual(fakeOptions[option], options[option]);
}

assert.notStrictEqual(fakeOptions, options);
});

it('should localize the cluster name', function() {
assert.strictEqual(bigtable.clusterName, CLUSTER_NAME);
});
Expand Down