Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage write streams should be able to use a pre-existing uri #1322

Closed
wants to merge 6 commits into from
Closed

Storage write streams should be able to use a pre-existing uri #1322

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4eaa832
Storage write streams should be able to use a pre-existing uri
May 16, 2016
8df1aa8
gcs-resumable-upload will ignore the uri if it is falsy
May 16, 2016
04aeace
Add uri parameter to jsdocs
May 16, 2016
006754c
Add myself to contributors
May 16, 2016
0fbd22f
Bump gcs-resumable-upload package
May 17, 2016
9a6afeb
Ensure a provided uri is passed to gcs-resumable-upload
May 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ensure a provided uri is passed to gcs-resumable-upload
  • Loading branch information
Ben Stahl committed May 17, 2016
commit 9a6afeb51aa28ff682a22a8f13f6dbfd4b98a53a
15 changes: 15 additions & 0 deletions test/storage/file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,21 @@ describe('File', function() {
writable.end('data');
});

it('should pass through a provided uri', function(done) {
var options = {
uri: 'https://www.googleapis.com/afakeuri'
};

var writable = file.createWriteStream(options);

file.startResumableUpload_ = function(stream, options_) {
assert.deepEqual(options_.uri, options.uri);
done();
};

writable.write('data');
});

describe('validation', function() {
var data = 'test';

Expand Down