Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction Documentation #623

Closed
stephenplusplus opened this issue May 22, 2015 · 3 comments · Fixed by #627
Closed

Transaction Documentation #623

stephenplusplus opened this issue May 22, 2015 · 3 comments · Fixed by #627
Assignees
@stephenplusplus
Labels
api: datastore Issues related to the Datastore API.
Milestone
Datastore Future

Comments

@stephenplusplus
Copy link
Contributor

Related: #621

Should we privatize transaction#begin and transaction#commit, removing them from the public docs and their usage in other Transaction examples?

A user goes through their Dataset instance to get a Transaction:

dataset.runInTransaction(transaction, done) {});

This calls transaction.begin immediately, and the done function returned to their callback is actually transaction.commit.

Having these methods appear in the docs is probably quite confusing, as the user shouldn't need (or be able to) begin a transaction that already began, or commit the transaction before calling done (commit) again.
@stephenplusplus stephenplusplus added the api: datastore Issues related to the Datastore API. label May 22, 2015
@stephenplusplus stephenplusplus mentioned this issue May 22, 2015
Closed
@abelino
Copy link

abelino commented May 22, 2015

Ohhh snap, this clears things up a lot!!! Thanks!!!

@ryanseys
Copy link
Contributor

Yeah these should be private.

@jgeewax jgeewax added this to the Datastore Future milestone May 25, 2015
@ryanseys ryanseys mentioned this issue May 26, 2015
Merged
@ryanseys
Copy link
Contributor

Oooh I'll address these in #627

@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 10, 2022
@renovate-bot
chore(deps): update dependency sinon to v14 (#623)
e8ae86a 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://github.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v14.0.0`](https://github.com/sinonjs/sinon/blob/HEAD/CHANGES.md#&#8203;1400)

[Compare Source](https://github.com/sinonjs/sinon/compare/v13.0.2...v14.0.0)

-   [`c2bbd826`](https://github.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00)
    Drop node 12 (Morgan Roderick)
    > And embrace Node 18
    >
    > See https://nodejs.org/en/about/releases/

*Released by Morgan Roderick on 2022-05-07.*

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-tasks).
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl added a commit that referenced this issue Nov 11, 2022
@daniel-sanche @gcf-owl-bot @sofisl
chore: added extra variables owlbot kokoro configs (#623)
f701bee 
* chore: added extra variables owlbot kokoro configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <[email protected]>
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@gcf-owl-bot
fix: make request optional in all cases (#623)
96df053 
... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0

Committer: @miraleung
PiperOrigin-RevId: 380641501

Source-Link: googleapis/googleapis@076f7e9

Source-Link: googleapis/googleapis-gen@27e4c88
sofisl pushed a commit that referenced this issue Jan 10, 2023
@release-please
chore: release 3.1.3 (#624)
de3ea0d 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.1.3](https://github.com/googleapis/nodejs-dlp/compare/v3.1.2...v3.1.3) (2021-06-22)


### Bug Fixes

* make request optional in all cases ([#623](https://github.com/googleapis/nodejs-dlp/issues/623)) ([77f45fb](https://github.com/googleapis/nodejs-dlp/commit/77f45fbcd1481079cc8f1bd10d5637da24405bce))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@takeratta takeratta mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
Datastore Future
Development

Successfully merging a pull request may close this issue.

Verify @example docs on npm test
4 participants
@jgeewax @ryanseys @stephenplusplus @abelino