Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage.channel stop request has invalid URL #1145

Closed
AVVS opened this issue Mar 2, 2016 · 1 comment
Closed

storage.channel stop request has invalid URL #1145

AVVS opened this issue Mar 2, 2016 · 1 comment
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@AVVS
Copy link
Contributor

AVVS commented Mar 2, 2016

channel id is used to construct request URI, and always results in 404 (gsutil has the same bug btw),

ie it should be: https://www.googleapis.com/storage/v1/channels/stop instead of https://www.googleapis.com/storage/v1/channels/channel-name/stop

this can be temporarily fixed with (since there is only 1 method for .channel, which is .stop - there are no checks on the interceptor

channel.interceptors.push({
  request: (requestOptions) => {
    requestOptions.uri = requestOptions.uri.replace(`${channel}/`, '');
    return requestOptions;
  },
});
@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 2, 2016
@stephenplusplus
Copy link
Contributor

Thanks for reporting! Sent a fix in #1146 -- feel free to try it out to make sure it works as intended.

sofisl pushed a commit that referenced this issue Nov 11, 2022
Source-Link: googleapis/synthtool@39652e3
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:41d5457ff79c3945782ab7e23bf4d617fd7bf3f2b03b6d84808010f7d2e10ca2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants