Merge pull request #68 from silvolu/master

FIX(storage): throw Error if bucket name is not passed to bucket constru...
googleapis · Jul 30, 2014 · 0765bdb · 0765bdb
2 parents ec51f08 + 0322432
commit 0765bdb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/storage/index.js b/lib/storage/index.js
@@ -146,6 +146,9 @@ ReadStream.prototype.pipe = function(dest, opts) {
  * create a bucket.
  */
 function Bucket(opts) {
+  if (!opts.bucketName) {
+    throw Error('A bucket name is needed to use Google Cloud Storage');
+  }
   this.bucketName = opts.bucketName;
   this.conn = new conn.Connection({
     keyFilename: opts.keyFilename,

diff --git a/test/storage.js b/test/storage.js
@@ -29,6 +29,10 @@ function createBucket() {
 
 describe('Bucket', function() {
 
+  it('should throw if a bucket name is not passed', function() {
+    assert.throws(function() { var bucket = new storage.Bucket(); }, Error);
+  })
+
   it('should list without a query', function(done) {
     var bucket = createBucket();
     bucket.makeReq = function(method, path, q, body, callback) {