Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [places] new module for places #9419

Closed
wants to merge 3 commits into from
Closed

feat: [places] new module for places #9419

wants to merge 3 commits into from

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented May 9, 2023

For b/281587773

Command to generate:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=places \
  --proto-path=google/maps/places \
  --name-pretty="Places API (New)" \
  --product-docs="https://developers.google.com/maps/documentation/places/web-service/" \
  --api-description="The Places API allows developers to access a variety of search and
    retrieval endpoints for a Place." \
  --api-id=places.googleapis.com \
  --cloud-api=false \
  --requires-billing=true \
  --distribution-name="com.google.maps:google-maps-places"

@snippet-bot
Copy link

snippet-bot bot commented May 9, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 7 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

suztomo
suztomo requested changes May 9, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use java-maps-places as the module name to match other maps-related modules?

@alicejli
Copy link
Contributor Author

alicejli commented May 9, 2023

Can you use java-maps-places as the module name to match other maps-related modules?

Ah yes sorry I missed that. Let me make a new PR.

@alicejli alicejli closed this May 9, 2023
@alicejli alicejli mentioned this pull request May 9, 2023
Merged
@alicejli alicejli reopened this May 9, 2023
@alicejli
Copy link
Contributor Author

alicejli commented May 9, 2023

Updated PR here: #9420

@alicejli alicejli closed this May 9, 2023
@alicejli alicejli deleted the new_module_java-places branch May 9, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo requested changes

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alicejli @suztomo @blakeli0