Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datacatalog : Cleanup dependency #5619

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Datacatalog : Cleanup dependency #5619

merged 3 commits into from
Jul 1, 2019

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Jul 1, 2019

towards #4383

@athakor athakor requested a review from a team as a code owner July 1, 2019 12:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #5619 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5619      +/-   ##
============================================
- Coverage     46.71%   46.71%   -0.01%     
- Complexity    24625    24639      +14     
============================================
  Files          2351     2351              
  Lines        256121   256121              
  Branches      29323    29318       -5     
============================================
- Hits         119647   119645       -2     
- Misses       127556   127557       +1     
- Partials       8918     8919       +1
Impacted Files Coverage Δ Complexity Δ
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b16af...cc5afac. Read the comment docs.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@sduskis sduskis merged commit a2223d5 into googleapis:master Jul 1, 2019
This was referenced Jul 2, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@athakor @sduskis @googlebot @pmakani @yoshi-kokoro