Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Pub/Sub client classes and unit tests #345

Merged
merged 5 commits into from
Nov 20, 2015
Merged

Generated Pub/Sub client classes and unit tests #345

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5068e1b
Generated Pub/Sub client classes and unit tests
garrettjonesgoogle Nov 10, 2015
c952c20
Fixing source paths and module configuration
garrettjonesgoogle Nov 11, 2015
4fbfb7b
Updates to address PR comments.
garrettjonesgoogle Nov 17, 2015
add0cc3
More updates to address PR comments
garrettjonesgoogle Nov 19, 2015
b9d8555
Third round of updates to address PR comments
garrettjonesgoogle Nov 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gcloud-java-gax/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<goals><goal>add-source</goal></goals>
<configuration>
<sources>
<source>generated/src/main</source>
<source>generated/src/main/java</source>
</sources>
</configuration>
</execution>
Expand Down
6 changes: 4 additions & 2 deletions gcloud-java-gax/src/main/java/io/gapi/gax/grpc/ServiceApiSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ public int getPort() {
}

/**
* An instance of ManagedChannel; shutdown will be called on this channel when
* the instance of LoggingServiceApi is shut down.
* The channel used to send requests to the service. Whichever service api class that
* this instance of ServiceApiSettings is passed to will call shutdown() on this
* channel. This injection mechanism is intended for use by unit tests to override
* the channel that would be created by default for real calls to the service.
*/
public ServiceApiSettings setChannel(ManagedChannel channel) {
this.channel = channel;
Expand Down
8 changes: 7 additions & 1 deletion gcloud-java-pubsub/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@
<artifactId>auto-value</artifactId>
<version>1.1</version>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.12</version>
<scope>test</scope>
</dependency>
</dependencies>
<build>
<plugins>
Expand All @@ -45,7 +51,7 @@
<goals><goal>add-source</goal></goals>
<configuration>
<sources>
<source>generated/src/main</source>
<source>generated/src/main/java</source>
</sources>
</configuration>
</execution>
Expand Down
Loading