-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerating Pub/Sub and Logging #1156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Aug 11, 2016
@@ -458,7 +458,7 @@ public Builder toBuilder() { | |||
// todo(mziccard) uncomment when #1042 gets fixed | |||
// builder.setCacheLookup(cacheLookup); | |||
builder.setCacheHit(cacheHit); | |||
builder.setValidatedWithOriginServer(cacheValidatedWithOriginServer); | |||
builder.setCacheValidatedWithOriginServer(cacheValidatedWithOriginServer); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
In the logging code, I renamed formatProjectName to formatParentName, and fixed the method that was accidentally made private. PTAL. |
LGTM! |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
… (googleapis#549) Source-Link: googleapis/synthtool@5d3c52f Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:b3f8a219abf58ed4a775da5b90934b34f477b74f6f4e5d15781694dcc67b6f41
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
Source-Link: googleapis/synthtool@5d3c52f Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:b3f8a219abf58ed4a775da5b90934b34f477b74f6f4e5d15781694dcc67b6f41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version updates:
Generated code changes:
Notes:
Proto/GAPIC configuration changes:
Sorry about the continued usage of baselines - we are working on a way to get rid of them.
FYI @michaelbausor @shinfan