Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-generate SecretManager v1beta1 client library #11402

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Jan 23, 2025

Secret Manager v1beta1 was not properly configured by Hermetic Build. This should now allow SecretManager v1beta1 to be regenerated properly.

@lqiu96 lqiu96 requested a review from blakeli0 January 23, 2025 03:05
@lqiu96 lqiu96 requested a review from a team as a code owner January 23, 2025 03:05
generation_config.yaml Outdated Show resolved Hide resolved
@diegomarquezp
Copy link
Contributor

2025-01-23T23:08:56.7084604Z Traceback (most recent call last):
2025-01-23T23:08:56.7095773Z   File "/home/runner/work/google-cloud-java/google-cloud-java/hermetic_build/release_note_generation/cli/generate_release_note.py", line 99, in <module>
2025-01-23T23:08:56.7097194Z     main()
2025-01-23T23:08:56.7097800Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
2025-01-23T23:08:56.7098574Z     return self.main(*args, **kwargs)
2025-01-23T23:08:56.7098920Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-23T23:08:56.7099575Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/click/core.py", line 1078, in main
2025-01-23T23:08:56.7100175Z     rv = self.invoke(ctx)
2025-01-23T23:08:56.7100536Z          ^^^^^^^^^^^^^^^^
2025-01-23T23:08:56.7101499Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
2025-01-23T23:08:56.7102196Z     return _process_result(sub_ctx.command.invoke(sub_ctx))
2025-01-23T23:08:56.7102567Z                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-23T23:08:56.7103195Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
2025-01-23T23:08:56.7103798Z     return ctx.invoke(self.callback, **ctx.params)
2025-01-23T23:08:56.7104280Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-23T23:08:56.7104849Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/click/core.py", line 783, in invoke
2025-01-23T23:08:56.7105436Z     return __callback(*args, **kwargs)
2025-01-23T23:08:56.7105721Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-23T23:08:56.7106752Z   File "/home/runner/work/google-cloud-java/google-cloud-java/hermetic_build/release_note_generation/cli/generate_release_note.py", line 92, in generate
2025-01-23T23:08:56.7107397Z     generate_pr_descriptions(
2025-01-23T23:08:56.7108086Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/release_note_generation/generate_pr_description.py", line 59, in generate_pr_descriptions
2025-01-23T23:08:56.7108767Z     description = get_repo_level_commit_messages(
2025-01-23T23:08:56.7109039Z                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-01-23T23:08:56.7109738Z   File "/opt/hostedtoolcache/Python/3.12.8/x64/lib/python3.12/site-packages/release_note_generation/generate_pr_description.py", line 114, in get_repo_level_commit_messages
2025-01-23T23:08:56.7110399Z     raise ValueError(
2025-01-23T23:08:56.7111026Z ValueError: current_commit (8692273, committed on 1728434268) should be newer than or equal to baseline_commit (00196e2, committed on 1736380372) (is this branch up to date with the base branch?).
2025-01-23T23:08:56.7431112Z ##[error]Process completed with exit code 1

This may be due to the main branch having a more up-to-date googleapis_committish. Let's try merging origin/main

@lqiu96 lqiu96 enabled auto-merge (squash) January 28, 2025 21:08
Copy link

snippet-bot bot commented Jan 28, 2025

Here is the summary of changes.

You are about to add 60 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lqiu96 lqiu96 closed this Jan 28, 2025
auto-merge was automatically disabled January 28, 2025 21:53

Pull request was closed

@lqiu96 lqiu96 reopened this Jan 28, 2025
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2025
versions.txt Outdated
Comment on lines 828 to 829
proto-google-cloud-secretmanager-v1beta1:2.56.0:2.57.0-SNAPSHOT
grpc-google-cloud-secretmanager-v1beta1:2.56.0:2.57.0-SNAPSHOT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 2.56.0 doesn't exist right now, I'm going to temporarily mark the current version as 2.57.0-SNAPSHOT for this PR and then revert it once it is in.

@lqiu96 lqiu96 closed this Jan 28, 2025
@lqiu96 lqiu96 reopened this Jan 28, 2025
@lqiu96 lqiu96 enabled auto-merge (squash) January 28, 2025 22:40
@lqiu96 lqiu96 merged commit c6559f6 into main Jan 28, 2025
31 checks passed
@lqiu96 lqiu96 deleted the secretmanager_v1beta1 branch January 28, 2025 22:44
@lqiu96 lqiu96 added the release-please:force-run To run release-please label Jan 28, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Jan 28, 2025
@lqiu96 lqiu96 added the release-please:force-run To run release-please label Jan 29, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Jan 29, 2025
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>1.51.0</summary>

## [1.51.0](https://github.com/googleapis/google-cloud-java/compare/v1.50.0...v1.51.0) (2025-01-29)


### Features

* [aiplatform] add Context Cache to v1 ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Add machine_spec, data_persistent_disk_spec, network_spec, euc_config, shielded_vm_config to `.google.cloud.aiplatform.v1beta1.NotebookRuntime` ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Add machine_spec, data_persistent_disk_spec, network_spec, euc_config, shielded_vm_config to message `.google.cloud.aiplatform.v1.NotebookRuntime` ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] add optimized config in v1 API ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] add per-modality token count break downs for GenAI APIs ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] add per-modality token count break downs for GenAI APIs ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] add retrieval_config to ToolConfig v1 ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] add retrieval_config to ToolConfig v1beta1 ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Add speculative decoding spec to DeployedModel proto ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] enable FeatureGroup IAM Methods in v1beta1 API version ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] enable FeatureView Service Account in v1 API version ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] enable UpdateFeatureMonitor in v1beta1 API version ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Expose code execution tool API to v1 ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Model Registry Checkpoint API ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Model Registry Checkpoint API ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Reasoning Engine v1 GAPIC release ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [aiplatform] Remove autorater config related visibility v1beta1 ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [backupdr] add InitializeServiceAPI ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [chat] A new field `custom_emoji_metadata` is added to message `.google.chat.v1.Annotation` ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [cloudbuild] Add option to enable structured logging ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [cloudcontrolspartner] A new method `CreateCustomer` is added to service `CloudControlsPartnerCore` ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [compute] Update Compute Engine API to revision 20250107 ([#975](https://github.com/googleapis/google-cloud-java/issues/975)) ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [datastream] A new field `ssl_config` is added to message `.google.cloud.datastream.v1.PostgresqlProfile` ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [maps-places] add more fuel type enum values ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [meet] Add methods for [configuring meeting spaces and members](https://developers.google.com/meet/api/guides/beta/configuration-beta) ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [monitoring] add active_only field to ListMetricDescriptorsRequest ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [network-management] expose the new v1 vpcflowlogs api proto ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [parametermanager] new module for parametermanager ([#11412](https://github.com/googleapis/google-cloud-java/issues/11412)) ([5e93c83](https://github.com/googleapis/google-cloud-java/commit/5e93c83739ba93cb6a9876ab66e10b34c15b5490))
* [redis-cluster] [Memorystore for Redis Cluster] Added support for maintenance window and rescheduling maintenance ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [redis-cluster] [Memorystore for Redis Cluster] Added support for maintenance window and rescheduling maintenance ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [tpu] Add UNKNOWN to TPU node state, This state will be used to prevent a node from being marked as READY during diagnose after it has failed repair ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [tpu] Introduce PerformMaintenance API ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [tpu] Promote network_configs field to v2 API ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))


### Bug Fixes

* [maps-places] add oauth scopes to Places proto ([a3b082e](https://github.com/googleapis/google-cloud-java/commit/a3b082eea5a4ddbb6b3717bf0b8d7c19cdd2fda5))
* **deps:** update dependency com.google.cloud:google-cloud-storage to v2.48.0 ([#11409](https://github.com/googleapis/google-cloud-java/issues/11409)) ([92c852e](https://github.com/googleapis/google-cloud-java/commit/92c852eab1f3fbc9a5f2a7a6a577a17b1494b334))
* **deps:** update the Java code generator (gapic-generator-java) to 2.52.0 ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* Re-generate SecretManager v1beta1 client library ([#11402](https://github.com/googleapis/google-cloud-java/issues/11402)) ([c6559f6](https://github.com/googleapis/google-cloud-java/commit/c6559f6cf6d62290d3639ee61e506102ac085cd6))
* update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#11410](https://github.com/googleapis/google-cloud-java/issues/11410)) ([34dfd0d](https://github.com/googleapis/google-cloud-java/commit/34dfd0dc9c5ca042aca0778e8d34b2ca072bfeb1))


### Documentation

* [analytics-admin] replace "GA4" with "Google Analytics" or "GA" in all comments ([a3b082e](https://github.com/googleapis/google-cloud-java/commit/a3b082eea5a4ddbb6b3717bf0b8d7c19cdd2fda5))
* [analytics-admin] replace "GA4" with "Google Analytics" or "GA" in all comments ([a3b082e](https://github.com/googleapis/google-cloud-java/commit/a3b082eea5a4ddbb6b3717bf0b8d7c19cdd2fda5))
* [container] broken (or ambiguous) markdown link ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [gsuite-addons] Minor documentation edits ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [maps-fleetengine-delivery] Refine Docs for Fleet Engine time related fields ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [maps-places] mark Places API client libraries as BETA ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [meet] improve docs for GetSpaceRequest, EndActiveConferenceRequest, ListConferenceRecordsRequest ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [orchestration-airflow] A comment for method `ListWorkloads` in service `Environments` is changed ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [scheduler] update comments ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [secretmanager] fix link in Markdown comments ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
* [secretmanager] updated comment for `customer_managed_encryption` in message `.google.cloud.secretmanager.v1.Secret` ([87de77d](https://github.com/googleapis/google-cloud-java/commit/87de77d00b5bb8bcea1046a412288386e65bba0d))
</details>

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants