feat: add java-vertexai to the monorepo #10129
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
| </parent> | ||
| <properties> | ||
| <site.installationModule>google-cloud-vertexai</site.installationModule> | ||
| <mockito.version>5.7.0</mockito.version> |
There was a problem hiding this comment.
I believe the mockito version is already managed.
There was a problem hiding this comment.
Changed my dependency to mockito-all without version specification. Thanks!
| * <p>Please refer to the GitHub repository's samples for more quickstart code snippets. | ||
| */ | ||
| @Generated("by gapic-generator-java") | ||
| public class EndpointServiceClient implements BackgroundResource { |
There was a problem hiding this comment.
Is EndpointServiceClient needed? I thought that only PredictionServiceClient was being added.
There was a problem hiding this comment.
I honestly don't know. Earlier I was trying to remove the endpoint proto but got an error message that was something like "endpoint service was not found" and gave up triming it further down. I'm not sure if it's related to the google.api.method_policy option in the rpc definition (can send an internal link to you via chat)
gapic-libraries-bom/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-vertexai-bom</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-vertexai:current} --> |
There was a problem hiding this comment.
Is 0.0.1 the version you want to launch with? If not, you should update it in versions.txt.
There was a problem hiding this comment.
Changed to 0.1.0-SNAPSHOT. Thank you!
java-vertexai/.OwlBot.yaml
Outdated
| # limitations under the License. | ||
|
|
||
|
|
||
| deep-remove-regex: |
There was a problem hiding this comment.
I read that OwlBot is not supposed to touch these files. Then do not add OwlBot configuration file. This will remove files that match these regular expression.
There was a problem hiding this comment.
Thanks for catching this! Removed the .Owlbot yaml file
| > [!IMPORTANT] | ||
| > Thanks for your interest in the Vertex AI SDKs! **You can start using this SDK and its samples on December 13, 2023.** Until then, check out our [blog post](https://blog.google/technology/ai/google-gemini-ai/) to learn more about Google's Gemini multimodal model. | ||
| The Vertex AI <language> SDK enables developers to use Google's state-of-the-art generative AI models (like Gemini) to build AI-powered features and applications. |
There was a problem hiding this comment.
<language>
It seems missed to be updated.
There was a problem hiding this comment.
The autogenerated file was manually modified to this and we'll flip the content before release (12/13)
meltsufin
added
the
do not merge
ZhenyiQ
force-pushed
the
main
branch
2 times, most recently
from
9ab5e4d to
8717173
Compare
generation/consolidate_config.sh
Outdated
| @@ -96,10 +96,10 @@ removeArtifactVersion 'dependency' 'google-api-services-cloudresourcemanager' | |||
| removeArtifactVersion 'dependency' 'google-api-services-storage' | |||
| removeArtifactVersion 'dependency' 'google-cloud-storage' | |||
| removeArtifactVersion 'plugin' 'maven-checkstyle-plugin' | |||
| removeArtifactVersion 'dependency' 'mockito-all' | |||
| removeArtifactVersion 'dependency' 'mockito-core' | |||
There was a problem hiding this comment.
I don't think any changes to this file are needed. This was relevant when we were migrating from split repos.
There was a problem hiding this comment.
Reverted this change!
meltsufin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
java-vertexai/.repo-metadata.json
Outdated
| "repo_short": "java-vertexai", | ||
| "distribution_name": "com.google.cloud:google-cloud-vertexai", | ||
| "api_id": "vertexai.googleapis.com", | ||
| "library_type": "GAPIC_AUTO", |
There was a problem hiding this comment.
We probably want to change this to GAPIC_COMBO as this library includes both handwritten and generated code. See an example in Spanner.
ZhenyiQ
force-pushed
the
main
branch
3 times, most recently
from
91ea2a4 to
475e7bd
Compare
meltsufin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
meltsufin
removed
the
do not merge
BEGIN_COMMIT_OVERRIDE
feat: [vertexai] Initial release of Vertex Java SDK (#10129)
END_COMMIT_OVERRIDE