Skip to content

Commit

Permalink
feat: [batch] Add comment to the unsupported order_by field of ListTa…
Browse files Browse the repository at this point in the history
…sksRequest (#9684)

* feat: Enable gpu driver version field on v1
docs: Mark `order_by` field in `ListTasksRequest` as not implemented.
docs: Improve url examples in comments

PiperOrigin-RevId: 550631094

Source-Link: googleapis/googleapis@a2223b1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/30139239002a1d592923b8cc55b87a9c02c248bd
Copy-Tag: eyJwIjoiamF2YS1iYXRjaC8uT3dsQm90LnlhbWwiLCJoIjoiMzAxMzkyMzkwMDJhMWQ1OTI5MjNiOGNjNTViODdhOWMwMmMyNDhiZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Add comment to the unsupported order_by field of ListTasksRequest

---
feat: Enable gpu driver version field on v1

---
feat: allow order_by for v1 ListJobs

---
feat: Improve url examples formats on Batch API comments
PiperOrigin-RevId: 552573521

Source-Link: googleapis/googleapis@c34b78b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/12deb79966c3c6791755d66749e1611799ee95ab
Copy-Tag: eyJwIjoiamF2YS1iYXRjaC8uT3dsQm90LnlhbWwiLCJoIjoiMTJkZWI3OTk2NmMzYzY3OTE3NTVkNjY3NDllMTYxMTc5OWVlOTVhYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Aug 2, 2023
1 parent cbf3dd5 commit c27566e
Show file tree
Hide file tree
Showing 23 changed files with 1,626 additions and 748 deletions.
4 changes: 2 additions & 2 deletions java-batch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.19.0</version>
<version>26.20.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -201,7 +201,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-preview-yellow
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-batch.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-batch/0.21.0
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-batch/0.22.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ public final ListJobsPagedResponse listJobs(String parent) {
* ListJobsRequest.newBuilder()
* .setParent("parent-995424086")
* .setFilter("filter-1274492040")
* .setOrderBy("orderBy-1207110587")
* .setPageSize(883849137)
* .setPageToken("pageToken873572522")
* .build();
Expand Down Expand Up @@ -648,6 +649,7 @@ public final ListJobsPagedResponse listJobs(ListJobsRequest request) {
* ListJobsRequest.newBuilder()
* .setParent("parent-995424086")
* .setFilter("filter-1274492040")
* .setOrderBy("orderBy-1207110587")
* .setPageSize(883849137)
* .setPageToken("pageToken873572522")
* .build();
Expand Down Expand Up @@ -680,6 +682,7 @@ public final UnaryCallable<ListJobsRequest, ListJobsPagedResponse> listJobsPaged
* ListJobsRequest.newBuilder()
* .setParent("parent-995424086")
* .setFilter("filter-1274492040")
* .setOrderBy("orderBy-1207110587")
* .setPageSize(883849137)
* .setPageToken("pageToken873572522")
* .build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ public class HttpJsonBatchServiceStub extends BatchServiceStub {
ProtoRestSerializer<ListJobsRequest> serializer =
ProtoRestSerializer.create();
serializer.putQueryParam(fields, "filter", request.getFilter());
serializer.putQueryParam(fields, "orderBy", request.getOrderBy());
serializer.putQueryParam(fields, "pageSize", request.getPageSize());
serializer.putQueryParam(fields, "pageToken", request.getPageToken());
serializer.putQueryParam(fields, "$alt", "json;enum-encoding=int");
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -88,58 +88,58 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "\004name\030\001 \001(\tB!\342A\001\002\372A\032\n\030batch.googleapis.c"
+ "om/Job\"P\n\020DeleteJobRequest\022\014\n\004name\030\001 \001(\t"
+ "\022\024\n\006reason\030\002 \001(\tB\004\342A\001\001\022\030\n\nrequest_id\030\004 \001"
+ "(\tB\004\342A\001\001\"X\n\017ListJobsRequest\022\016\n\006parent\030\001 "
+ "\001(\t\022\016\n\006filter\030\004 \001(\t\022\021\n\tpage_size\030\002 \001(\005\022\022"
+ "\n\npage_token\030\003 \001(\t\"j\n\020ListJobsResponse\022("
+ "\n\004jobs\030\001 \003(\0132\032.google.cloud.batch.v1.Job"
+ "\022\027\n\017next_page_token\030\002 \001(\t\022\023\n\013unreachable"
+ "\030\003 \003(\t\"\202\001\n\020ListTasksRequest\0227\n\006parent\030\001 "
+ "\001(\tB\'\342A\001\002\372A \n\036batch.googleapis.com/TaskG"
+ "roup\022\016\n\006filter\030\002 \001(\t\022\021\n\tpage_size\030\003 \001(\005\022"
+ "\022\n\npage_token\030\004 \001(\t\"m\n\021ListTasksResponse"
+ "\022*\n\005tasks\030\001 \003(\0132\033.google.cloud.batch.v1."
+ "Task\022\027\n\017next_page_token\030\002 \001(\t\022\023\n\013unreach"
+ "able\030\003 \003(\t\"B\n\016GetTaskRequest\0220\n\004name\030\001 \001"
+ "(\tB\"\342A\001\002\372A\033\n\031batch.googleapis.com/Task\"\207"
+ "\002\n\021OperationMetadata\0225\n\013create_time\030\001 \001("
+ "\0132\032.google.protobuf.TimestampB\004\342A\001\003\0222\n\010e"
+ "nd_time\030\002 \001(\0132\032.google.protobuf.Timestam"
+ "pB\004\342A\001\003\022\024\n\006target\030\003 \001(\tB\004\342A\001\003\022\022\n\004verb\030\004 "
+ "\001(\tB\004\342A\001\003\022\034\n\016status_message\030\005 \001(\tB\004\342A\001\003\022"
+ "$\n\026requested_cancellation\030\006 \001(\010B\004\342A\001\003\022\031\n"
+ "\013api_version\030\007 \001(\tB\004\342A\001\0032\266\010\n\014BatchServic"
+ "e\022\233\001\n\tCreateJob\022\'.google.cloud.batch.v1."
+ "CreateJobRequest\032\032.google.cloud.batch.v1"
+ ".Job\"I\332A\021parent,job,job_id\202\323\344\223\002/\"(/v1/{p"
+ "arent=projects/*/locations/*}/jobs:\003job\022"
+ "\203\001\n\006GetJob\022$.google.cloud.batch.v1.GetJo"
+ "bRequest\032\032.google.cloud.batch.v1.Job\"7\332A"
+ "\004name\202\323\344\223\002*\022(/v1/{name=projects/*/locati"
+ "ons/*/jobs/*}\022\317\001\n\tDeleteJob\022\'.google.clo"
+ "ud.batch.v1.DeleteJobRequest\032\035.google.lo"
+ "ngrunning.Operation\"z\312A@\n\025google.protobu"
+ "f.Empty\022\'google.cloud.batch.v1.Operation"
+ "Metadata\332A\004name\202\323\344\223\002**(/v1/{name=project"
+ "s/*/locations/*/jobs/*}\022\226\001\n\010ListJobs\022&.g"
+ "oogle.cloud.batch.v1.ListJobsRequest\032\'.g"
+ "oogle.cloud.batch.v1.ListJobsResponse\"9\332"
+ "A\006parent\202\323\344\223\002*\022(/v1/{parent=projects/*/l"
+ "ocations/*}/jobs\022\233\001\n\007GetTask\022%.google.cl"
+ "oud.batch.v1.GetTaskRequest\032\033.google.clo"
+ "ud.batch.v1.Task\"L\332A\004name\202\323\344\223\002?\022=/v1/{na"
+ "me=projects/*/locations/*/jobs/*/taskGro"
+ "ups/*/tasks/*}\022\256\001\n\tListTasks\022\'.google.cl"
+ "oud.batch.v1.ListTasksRequest\032(.google.c"
+ "loud.batch.v1.ListTasksResponse\"N\332A\006pare"
+ "nt\202\323\344\223\002?\022=/v1/{parent=projects/*/locatio"
+ "ns/*/jobs/*/taskGroups/*}/tasks\032H\312A\024batc"
+ "h.googleapis.com\322A.https://www.googleapi"
+ "s.com/auth/cloud-platformB\253\001\n\031com.google"
+ ".cloud.batch.v1B\nBatchProtoP\001Z/cloud.goo"
+ "gle.com/go/batch/apiv1/batchpb;batchpb\242\002"
+ "\003GCB\252\002\025Google.Cloud.Batch.V1\312\002\025Google\\Cl"
+ "oud\\Batch\\V1\352\002\030Google::Cloud::Batch::V1b"
+ "\006proto3"
+ "(\tB\004\342A\001\001\"p\n\017ListJobsRequest\022\016\n\006parent\030\001 "
+ "\001(\t\022\016\n\006filter\030\004 \001(\t\022\026\n\010order_by\030\005 \001(\tB\004\342"
+ "A\001\001\022\021\n\tpage_size\030\002 \001(\005\022\022\n\npage_token\030\003 \001"
+ "(\t\"j\n\020ListJobsResponse\022(\n\004jobs\030\001 \003(\0132\032.g"
+ "oogle.cloud.batch.v1.Job\022\027\n\017next_page_to"
+ "ken\030\002 \001(\t\022\023\n\013unreachable\030\003 \003(\t\"\202\001\n\020ListT"
+ "asksRequest\0227\n\006parent\030\001 \001(\tB\'\342A\001\002\372A \n\036ba"
+ "tch.googleapis.com/TaskGroup\022\016\n\006filter\030\002"
+ " \001(\t\022\021\n\tpage_size\030\003 \001(\005\022\022\n\npage_token\030\004 "
+ "\001(\t\"m\n\021ListTasksResponse\022*\n\005tasks\030\001 \003(\0132"
+ "\033.google.cloud.batch.v1.Task\022\027\n\017next_pag"
+ "e_token\030\002 \001(\t\022\023\n\013unreachable\030\003 \003(\t\"B\n\016Ge"
+ "tTaskRequest\0220\n\004name\030\001 \001(\tB\"\342A\001\002\372A\033\n\031bat"
+ "ch.googleapis.com/Task\"\207\002\n\021OperationMeta"
+ "data\0225\n\013create_time\030\001 \001(\0132\032.google.proto"
+ "buf.TimestampB\004\342A\001\003\0222\n\010end_time\030\002 \001(\0132\032."
+ "google.protobuf.TimestampB\004\342A\001\003\022\024\n\006targe"
+ "t\030\003 \001(\tB\004\342A\001\003\022\022\n\004verb\030\004 \001(\tB\004\342A\001\003\022\034\n\016sta"
+ "tus_message\030\005 \001(\tB\004\342A\001\003\022$\n\026requested_can"
+ "cellation\030\006 \001(\010B\004\342A\001\003\022\031\n\013api_version\030\007 \001"
+ "(\tB\004\342A\001\0032\266\010\n\014BatchService\022\233\001\n\tCreateJob\022"
+ "\'.google.cloud.batch.v1.CreateJobRequest"
+ "\032\032.google.cloud.batch.v1.Job\"I\332A\021parent,"
+ "job,job_id\202\323\344\223\002/\"(/v1/{parent=projects/*"
+ "/locations/*}/jobs:\003job\022\203\001\n\006GetJob\022$.goo"
+ "gle.cloud.batch.v1.GetJobRequest\032\032.googl"
+ "e.cloud.batch.v1.Job\"7\332A\004name\202\323\344\223\002*\022(/v1"
+ "/{name=projects/*/locations/*/jobs/*}\022\317\001"
+ "\n\tDeleteJob\022\'.google.cloud.batch.v1.Dele"
+ "teJobRequest\032\035.google.longrunning.Operat"
+ "ion\"z\312A@\n\025google.protobuf.Empty\022\'google."
+ "cloud.batch.v1.OperationMetadata\332A\004name\202"
+ "\323\344\223\002**(/v1/{name=projects/*/locations/*/"
+ "jobs/*}\022\226\001\n\010ListJobs\022&.google.cloud.batc"
+ "h.v1.ListJobsRequest\032\'.google.cloud.batc"
+ "h.v1.ListJobsResponse\"9\332A\006parent\202\323\344\223\002*\022("
+ "/v1/{parent=projects/*/locations/*}/jobs"
+ "\022\233\001\n\007GetTask\022%.google.cloud.batch.v1.Get"
+ "TaskRequest\032\033.google.cloud.batch.v1.Task"
+ "\"L\332A\004name\202\323\344\223\002?\022=/v1/{name=projects/*/lo"
+ "cations/*/jobs/*/taskGroups/*/tasks/*}\022\256"
+ "\001\n\tListTasks\022\'.google.cloud.batch.v1.Lis"
+ "tTasksRequest\032(.google.cloud.batch.v1.Li"
+ "stTasksResponse\"N\332A\006parent\202\323\344\223\002?\022=/v1/{p"
+ "arent=projects/*/locations/*/jobs/*/task"
+ "Groups/*}/tasks\032H\312A\024batch.googleapis.com"
+ "\322A.https://www.googleapis.com/auth/cloud"
+ "-platformB\253\001\n\031com.google.cloud.batch.v1B"
+ "\nBatchProtoP\001Z/cloud.google.com/go/batch"
+ "/apiv1/batchpb;batchpb\242\002\003GCB\252\002\025Google.Cl"
+ "oud.Batch.V1\312\002\025Google\\Cloud\\Batch\\V1\352\002\030G"
+ "oogle::Cloud::Batch::V1b\006proto3"
};
descriptor =
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(
Expand Down Expand Up @@ -185,7 +185,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
new com.google.protobuf.GeneratedMessageV3.FieldAccessorTable(
internal_static_google_cloud_batch_v1_ListJobsRequest_descriptor,
new java.lang.String[] {
"Parent", "Filter", "PageSize", "PageToken",
"Parent", "Filter", "OrderBy", "PageSize", "PageToken",
});
internal_static_google_cloud_batch_v1_ListJobsResponse_descriptor =
getDescriptor().getMessageTypes().get(4);
Expand Down
Loading

0 comments on commit c27566e

Please sign in to comment.