Updating Watch conformance tests (#3202)

googleapis · Apr 27, 2018 · 4108659 · 4108659
1 parent 0097ffa
commit 4108659
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Watch.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Watch.java
@@ -196,8 +196,9 @@ public synchronized void onNext(ListenResponse listenResponse) {
             }
             break;
           case ADD:
-            Preconditions.checkState(
-                WATCH_TARGET_ID == change.getTargetIds(0), "Target ID must be 0xD0");
+            if (WATCH_TARGET_ID != change.getTargetIds(0)) {
+              closeStream(FirestoreException.invalidState("Target ID must be 0x01"));
+            }
             break;
           case REMOVE:
             Status status =

diff --git a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/ConformanceTest.java b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/ConformanceTest.java
@@ -439,7 +439,7 @@ private void runQueryTest(TestDefinition.QueryTest testCase) {
     }
   }
 
-  private void runWatchTest(TestDefinition.ListenTest testCase)
+  private void runWatchTest(final TestDefinition.ListenTest testCase)
       throws ExecutionException, InterruptedException {
     final SettableApiFuture<Void> testCaseStarted = SettableApiFuture.create();
     final SettableApiFuture<Void> testCaseFinished = SettableApiFuture.create();
@@ -464,10 +464,20 @@ public ApiStreamObserver<ListenRequest> answer(InvocationOnMock invocationOnMock
               public void onEvent(
                   @Nullable QuerySnapshot actualSnapshot, @Nullable FirestoreException error) {
                 try {
-                  Assert.assertFalse(expectedSnapshots.isEmpty());
-                  Snapshot expectedSnapshot = expectedSnapshots.remove(0);
-                  Assert.assertEquals(convertQuerySnapshot(expectedSnapshot), actualSnapshot);
-                  if (expectedSnapshots.isEmpty()) {
+                  if (actualSnapshot != null) {
+                    Assert.assertNull(error);
+                    Assert.assertFalse(expectedSnapshots.isEmpty());
+                    Snapshot expectedSnapshot = expectedSnapshots.remove(0);
+                    Assert.assertEquals(convertQuerySnapshot(expectedSnapshot), actualSnapshot);
+                    if (expectedSnapshots.isEmpty()) {
+                      if (!testCase.getIsError()) {
+                        testCaseFinished.set(null);
+                      }
+                    }
+                  } else { // Error case
+                    Assert.assertNotNull(error);
+                    Assert.assertTrue(expectedSnapshots.isEmpty());
+                    Assert.assertTrue(testCase.getIsError());
                     testCaseFinished.set(null);
                   }
                 } catch (AssertionError e) {

diff --git a/google-cloud-firestore/src/test/resources/test-suite.binproto b/google-cloud-firestore/src/test/resources/test-suite.binproto