Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bigtable): Cancel context #9273

Merged
merged 4 commits into from
Jan 23, 2024
Merged

test(bigtable): Cancel context #9273

merged 4 commits into from
Jan 23, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Jan 17, 2024

This PR resolves the below warning:

the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak

@bhshkh bhshkh requested review from a team as code owners January 17, 2024 23:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the Bigtable API. labels Jan 17, 2024
@bhshkh bhshkh requested a review from gkevinzheng January 17, 2024 23:26
@bhshkh bhshkh enabled auto-merge (squash) January 23, 2024 23:16
@bhshkh bhshkh merged commit c0a7049 into googleapis:main Jan 23, 2024
9 of 12 checks passed
@bhshkh bhshkh deleted the test/cbt-cleanup-tests branch January 23, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhshkh @kolea2 @gkevinzheng