chore(bigquery/storage/managedwriter): add client instrumentation #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds instrumentation for this client to aid in debugging scenarios with the write backend
product-auto-label
bot
added
size: s
shollyman
changed the title
product-auto-label
bot
added
size: m
yirutang
reviewed
Aug 5, 2022
| @@ -70,7 +70,7 @@ func WithMaxInflightBytes(n int) WriterOption { | |||
| // This is generally for diagnostic purposes only. | |||
| func WithTraceID(traceID string) WriterOption { | |||
| return func(ms *ManagedStream) { | |||
| ms.streamSettings.TraceID = traceID | |||
| ms.streamSettings.TraceID = buildTraceID(traceID) | |||
There was a problem hiding this comment.
Do you want to allow users to add in their own trace id?
There was a problem hiding this comment.
This changes from just setting the traceID in total to building a prefix for the library, and the user-specific trace ID. Same as jsonwriter etc.
There was a problem hiding this comment.
take a look at options_test.go for the expected output
codyoss
approved these changes
Aug 9, 2022
shollyman
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
shollyman
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
shollyman
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds instrumentation for this client to aid in debugging scenarios with
the write backend