Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): migrate Writer #6452

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

tritone
Copy link
Contributor

@tritone tritone commented Aug 1, 2022

Migrate Writer to use the transport-agnostic interface. A few
minor fixes:

  • Pass in retry, idempotency and user project via settings rather
    than determining below interface.
  • Use default generation since this can't be sent for this call.

Migrate Writer to use the transport-agnostic interface. A few
minor fixes:

* Pass in retry, idempotency and user project via settings rather
than determining below interface.
* Use default generation since this can't be sent for this call.
@tritone tritone requested review from a team as code owners August 1, 2022 03:27
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Aug 1, 2022
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow a remarkably clean PR! That went smoother than I thought tbh considering complexities of Writer, great stuff Chris.

@tritone tritone enabled auto-merge (squash) August 1, 2022 21:31
@tritone tritone merged commit 728ab63 into googleapis:storage-refactor Aug 1, 2022
@tritone tritone deleted the writer-migrate branch August 1, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants