Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): migrate bucket methods #6438

Merged
merged 5 commits into from
Jul 29, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jul 27, 2022

Migrate Bucket operations to transport-agnostic interface. Integration tests pass locally

  • DeleteBucket
  • GetBucket
  • UpdateBucket
  • LockBucketRetentionPolicy
  • ListObjects

Part of the migration

  • removed Bucket helpers new{Get/Delete/Patch}Call
  • similar to ListBuckets, removed internal fetch method that is no longer used by the iterator

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the Cloud Storage API. labels Jul 27, 2022
@cojenco cojenco marked this pull request as ready for review July 27, 2022 22:50
@cojenco cojenco requested review from a team as code owners July 27, 2022 22:50
@cojenco
Copy link
Contributor Author

cojenco commented Jul 28, 2022

@tritone thanks for the review.

Wanted to confirm with you that this note is out of date. Looking at our external docs, this should be available to the general public? If so, I'll remove this part of the doc.

@tritone
Copy link
Contributor

tritone commented Jul 29, 2022

@tritone thanks for the review.

Wanted to confirm with you that this note is out of date. Looking at our external docs, this should be available to the general public? If so, I'll remove this part of the doc.

Yup that's correct, feel free to remove. We should go through at some point and audit these, I think there are some other ones we can get rid of also (e.g. HMAC)

@cojenco cojenco merged commit 4fa01ba into googleapis:storage-refactor Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants