Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): migrate IAM operations #6437

Merged
merged 3 commits into from
Jul 28, 2022
Merged

chore(storage): migrate IAM operations #6437

merged 3 commits into from
Jul 28, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jul 27, 2022

Migrate IAM operations to transport-agnostic interface

  • GetIamPolicy
  • SetIamPolicy
  • TestIamPermissions

This PR adds *Client to iamClient so we can access the transport-agnostic interface
Integration tests pass locally for IAM

@cojenco cojenco requested review from a team as code owners July 27, 2022 17:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Jul 27, 2022
noahdietz
noahdietz reviewed Jul 27, 2022
View reviewed changes
@cojenco cojenco merged commit 5df3a32 into googleapis:storage-refactor Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cojenco @tritone @noahdietz