chore(storage): migrate top-level methods

[cojenco]

Migrate few top-level methods to transport-agnostic interface.

• GetServiceAccount
• ListBuckets
• CreateBucket*

*Interface refactoring
Shown in the current implementation, bucketName is referenced from BucketHandle, so proposing to include bucket string as an arg for method CreateBucket()

Integration tests pass locally

[tritone]

Nice catch on this

[cojenco]

@tritone @noahdietz Any thoughts on adding retryConfig to BucketIterator... this is what I've done for now

Moving to the new interface detaches referencing Client (and client.retry) in BucketIterator, like so

This stems from a failed test unable to find retryConfig from Client

[noahdietz]

@tritone @noahdietz Any thoughts on adding retryConfig to BucketIterator... this is what I've done for now

I think that is fine. Did you have a particular concern? I did notice though that the actual API calls still reference s.retry - should that be it.retry instead? Can't comment on something not in the scope of the diff in GH Reviews I guess :)

Moving to the new interface detaches referencing Client (and client.retry) in BucketIterator

Are we able to/should we remove the BucketIterator client *Client field as a result? Haven't looked to see if it is referenced anywhere else.

[cojenco]

Are we able to/should we remove the BucketIterator client *Client field as a result? Haven't looked to see if it is referenced anywhere else.

Great callout, Noah, client *Client field should be removed from BucketIterator. That helped me discover a todo to remove the no-longer used fetch method, which is the other only place referencing client field :)

Also spoke to Chris and realized my original question is more of a test issue. The call is retrieving retryConfig with no concerns, so removing the now-outdated test.