Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): migrate HMAC operations #6430

Merged
merged 1 commit into from
Jul 26, 2022
Merged

chore(storage): migrate HMAC operations #6430

merged 1 commit into from
Jul 26, 2022

Conversation

noahdietz
Copy link
Contributor

Migrate HMAC operations to transport-agnostic interface.

Integration tests pass locally for HMAC operations.

@noahdietz noahdietz requested review from tritone and cojenco July 26, 2022 21:38
@noahdietz noahdietz requested review from a team as code owners July 26, 2022 21:38
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Jul 26, 2022
tritone
tritone approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@noahdietz noahdietz merged commit 6ad9f3f into googleapis:storage-refactor Jul 26, 2022
@noahdietz noahdietz deleted the hmac-integration branch July 26, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@cojenco cojenco Awaiting requested review from cojenco

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @tritone