chore(storage): gRPC inject bucket ID in header for write #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
noahdietz
force-pushed
the
storage-refactor
branch
from
4e12635 to
2971037
Compare
noahdietz
force-pushed
the
write-obj-header
branch
from
a022df1 to
046aa72
Compare
tritone
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gRPC, include the
bucketID (not resource name) in thex-goog-request-paramsheader with the keybucketon the initial WriteObject RPC. All other RPCs, which are Unary on the client-side, are handled by the GAPIC layer for this.Instead of writing yet-another-header-injection helper, I exported the one form the GAPIC layer to reuse in the Veneer.
Fixes http://b/238793493 for Go.