Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firestore): Clarify Transaction.Get error code #6121

Merged
merged 9 commits into from
Aug 5, 2022

Conversation

ordovicia
Copy link
Contributor

@ordovicia ordovicia commented Jun 2, 2022

Clarifies that Transaction.Get() returns an error with NotFound status code.

DocumentRef.Get() comment already states that it returns NotFound error.

// Get retrieves the document. If the document does not exist, Get return a NotFound error, which
// can be checked with
// status.Code(err) == codes.NotFound
// In that case, Get returns a non-nil DocumentSnapshot whose Exists method return false and whose
// ReadTime is the time of the failed read operation.
func (d *DocumentRef) Get(ctx context.Context) (_ *DocumentSnapshot, err error) {

Fixes #6174

Clarifies that `Transaction.Get()` returns an error with `NotFound` status code.
@ordovicia ordovicia requested review from enocom, telpirion and a team as code owners June 2, 2022 07:36
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 2, 2022
@google-cla
Copy link

google-cla bot commented Jun 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jun 2, 2022
@ordovicia ordovicia changed the title chore(firestore): Clarify Transactioln.Get error code chore(firestore): Clarify Transaction.Get error code Jun 7, 2022
@ordovicia
Copy link
Contributor Author

@enocom @telpirion Please take a look. Thank you.

@telpirion
Copy link
Contributor

@ordovicia Please create a GitHub issue to track your request, per CONTRIBUTING guidelines. Thanks!

@ordovicia
Copy link
Contributor Author

Ah, sorry. I created an issue #6174.

@ordovicia
Copy link
Contributor Author

@telpirion @enocom Hi, please take a look again. Thank you.

@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jul 2, 2022
@ordovicia
Copy link
Contributor Author

@telpirion @enocom Ping?

@ordovicia
Copy link
Contributor Author

@telpirion @enocom Ping?

@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Aug 1, 2022
@ordovicia
Copy link
Contributor Author

@telpirion @enocom Ping?

@enocom
Copy link
Member

enocom commented Aug 5, 2022

@ordovicia Sorry for the slow response. This got lost in all my other GitHub emails. Thanks for the docs update!

@enocom enocom added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2022
@enocom enocom merged commit 0fe3506 into googleapis:main Aug 5, 2022
@ordovicia ordovicia deleted the patch-1 branch August 6, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firestore: Transaction.Get() is missing document about error code
4 participants