-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(firestore): Clarify Transaction.Get error code #6121
Conversation
Clarifies that `Transaction.Get()` returns an error with `NotFound` status code.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@enocom @telpirion Please take a look. Thank you. |
@ordovicia Please create a GitHub issue to track your request, per CONTRIBUTING guidelines. Thanks! |
Ah, sorry. I created an issue #6174. |
@telpirion @enocom Hi, please take a look again. Thank you. |
@telpirion @enocom Ping? |
@telpirion @enocom Ping? |
@telpirion @enocom Ping? |
@ordovicia Sorry for the slow response. This got lost in all my other GitHub emails. Thanks for the docs update! |
Clarifies that
Transaction.Get()
returns an error withNotFound
status code.DocumentRef.Get()
comment already states that it returnsNotFound
error.google-cloud-go/firestore/docref.go
Lines 66 to 71 in 06721e0
Fixes #6174