Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): add GetServiceAccount implementation #5884

Merged
merged 6 commits into from
Apr 14, 2022
Merged

chore(storage): add GetServiceAccount implementation #5884

merged 6 commits into from
Apr 14, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 12, 2022 •
edited
Loading

add GetServiceAccount implementation

  • gRPC GetServiceAccount method
  • HTTP GetServiceAccount method
  • basic emulator test

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Apr 12, 2022
@cojenco cojenco marked this pull request as ready for review April 12, 2022 21:35
@cojenco cojenco requested review from a team as code owners April 12, 2022 21:35
@cojenco cojenco requested review from noahdietz and tritone April 13, 2022 17:38
noahdietz
noahdietz reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @cojenco, I'll let @tritone Approve this one.

tritone
tritone reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with idempotency, otherwise LGTM!

@noahdietz noahdietz enabled auto-merge (squash) April 14, 2022 23:16
@noahdietz noahdietz merged commit fc7377f into googleapis:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz left review comments

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cojenco @tritone @noahdietz