test(logging): add kokoro build script for environment tests #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: logging
freelerobot
added
priority: p2
codyoss
reviewed
Mar 19, 2021
| env | grep KOKORO | ||
|
|
||
| # Set up service account credentials | ||
| export GOOGLE_APPLICATION_CREDENTIALS=$KOKORO_KEYSTORE_DIR/72523_go_integration_service_account |
There was a problem hiding this comment.
nit: Nothing that get logged here is secret today, but I would still just just suggest moving this to the top before set -x is enabled in case something more sensitive shows up in the future.
There was a problem hiding this comment.
Sounds good. Tis moved.
@codyoss Are you ok with my using the following?
-
I'm using go_integration_service_account from keystore. I may need to add IAM permissions to deploy CloudRun and CloudFunctions (required by the tests). Is that ok or should I create a new SA for this?
-
I'm putting this environment script under /kokoro directory. Let me know if you want me to nest it somewhere else!
There was a problem hiding this comment.
Thanks for the PR!
codyoss
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This environment test script runs logging & error reporting tests from this submodule. It deploys various GCP services like Cloud Run, Functions, GKE, etc, write logs, and tests whether the log entries are as expected.
Questions:
go_integration_service_accountfrom keystore. I may need to add IAM permissions to deploy CloudRun and CloudFunctions (required by the tests). Is that ok or should I create a new SA for this?Please don't hestitate to let me know if this can be more cleanly introduced into this repo. Thanks for any pointers.