chore(internal): stop generating Ads packages in genproto #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These packages don't have a corresponding client library (in cloud.google.com/go or another module). They aren't ready for production use. So, we're going to stop generating them for now and will revisit in the future when ready. A go-genproto PR will remove the existing Ads packages. If needed, these packages can be generated locally or as part of a build process. However, we're not ready to generate and publish them automatically.
google-cla
bot
added
the
cla: yes
|
LGTM |
tbpg
added a commit
to googleapis/go-genproto
that referenced
this pull request
Nov 16, 2020
These packages do not have a corresponding client library that uses them and are untested with the production API. Therefore, they are not ready for production use. In the future, we will investigate the best way to generate these APIs while making sure they have a high level of reliability. If needed, you can use protoc to generate Go packages for these protos locally or during your build process. You can also pin to an older version of this module; however, you won't be able to use updates to other APIs in this module. See googleapis/google-cloud-go#3214 for the corresponding update to stop updating/generating these packages.
hongalex
reviewed
Nov 16, 2020
| @@ -110,7 +123,7 @@ func regenGenproto(ctx context.Context, genprotoDir, googleapisDir, protoDir str | |||
| // Run protoc on all protos of all packages. | |||
| grp, _ := errgroup.WithContext(ctx) | |||
| for pkg, fnames := range pkgFiles { | |||
| if !strings.HasPrefix(pkg, "google.golang.org/genproto") || denylist[pkg] { | |||
| if !strings.HasPrefix(pkg, "google.golang.org/genproto") || denylist[pkg] || hasPrefix(pkg, skipPrefixes) { | |||
There was a problem hiding this comment.
If skipPrefixes gets larger, it would be more efficient to preemptively remove strings that match the prefix from pkgFiles rather than checking it everytime in this for loop. Considering the size of skipPrefixes for now, I don't think it's a blocking optimization.
There was a problem hiding this comment.
I agree on both counts. Going for simplicity for now.
hongalex
approved these changes
Nov 16, 2020
aohren
approved these changes
Nov 16, 2020
tbpg
commented
Nov 16, 2020
| @@ -110,7 +123,7 @@ func regenGenproto(ctx context.Context, genprotoDir, googleapisDir, protoDir str | |||
| // Run protoc on all protos of all packages. | |||
| grp, _ := errgroup.WithContext(ctx) | |||
| for pkg, fnames := range pkgFiles { | |||
| if !strings.HasPrefix(pkg, "google.golang.org/genproto") || denylist[pkg] { | |||
| if !strings.HasPrefix(pkg, "google.golang.org/genproto") || denylist[pkg] || hasPrefix(pkg, skipPrefixes) { | |||
There was a problem hiding this comment.
I agree on both counts. Going for simplicity for now.
tbpg
added
the
automerge
tbpg
added a commit
to googleapis/go-genproto
that referenced
this pull request
Nov 16, 2020
These packages do not have a corresponding client library that uses them and are untested with the production API. Therefore, they are not ready for production use. In the future, we will investigate the best way to generate these APIs while making sure they have a high level of reliability. If needed, you can use protoc to generate Go packages for these protos locally or during your build process. You can also pin to an older version of this module; however, you won't be able to use updates to other APIs in this module. See googleapis/google-cloud-go#3214 for the corresponding update to stop updating/generating these packages.
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These packages don't have a corresponding client library (in
cloud.google.com/go or another module). They aren't ready for production
use. So, we're going to stop generating them for now and will revisit
in the future when ready.
A go-genproto PR will remove the existing Ads packages.
If needed, these packages can be generated locally or as part of a build
process. However, we're not ready to generate and publish them
automatically.
@AnashOommen @aohren