test(storage): fix emulated tests for metadata on read #11387
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
BrennaEpp
reviewed
Jan 7, 2025
Comment on lines
+854
to
+857
| for key, expectedValue := range expectedMetadata { | ||
| actualValue, ok := gotMetaData[key] | ||
| if !ok || actualValue != expectedValue { | ||
| t.Fatalf("Object Metadata: Expected key %q with value %q, but got %q", key, expectedValue, actualValue) |
There was a problem hiding this comment.
I assume this fails if one of the expected keys is not in the metadata (!ok would return true?), but can you/did you double check?
There was a problem hiding this comment.
I tested against the testbench manually and good news it's running in kokoro now too. So this should fail if an expected key is not in gotMetadata or if there is a mismatch
danielduhh
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.