Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiler: update protobuf #8585

Closed
trevorwng opened this issue Sep 18, 2023 · 2 comments · Fixed by #7555
Closed

profiler: update protobuf #8585

trevorwng opened this issue Sep 18, 2023 · 2 comments · Fixed by #7555
Assignees
@punya @noahdietz
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. type: cleanup An internal cleanup or hygiene concern.

Comments

@trevorwng
Copy link

As github.com/golang/protobuf is deprecated, are there any plans to update it
@trevorwng trevorwng added the triage me I really want to be triaged. label Sep 18, 2023
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the Cloud Profiler API. label Sep 18, 2023
@cc4i
Copy link

cc4i commented Sep 28, 2023

Do you have any update on that? Thanks

@noahdietz noahdietz added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Oct 16, 2023
@noahdietz noahdietz mentioned this issue Oct 16, 2023
Merged
@noahdietz
Copy link
Contributor

I don't work on profiler, but on rotation for this repo, I just decided to do it: #8730

@noahdietz noahdietz self-assigned this Oct 16, 2023
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 16, 2023
@noahdietz
fix(profiler): migrate to protobuf-go v2 (#8730)
deeb583 
Refactors all protobuf-go v1 references in `cloud.google.com/go/profiler` to protobuf-go v2. This does remove a number of error scenarios and I'm not sure if those are actually real or not, I am just doing an in place refactor.

Updates #8585
@release-please release-please bot mentioned this issue Oct 16, 2023
Merged
@noahdietz noahdietz linked a pull request Oct 18, 2023 that will close this issue
chore(main): release profiler 0.4.0 #7555
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 18, 2023
@release-please
chore(main): release profiler 0.4.0 (#7555)
74b1547 
🤖 I have created a release *beep* *boop*
---


## [0.4.0](https://github.com/googleapis/google-cloud-go/compare/profiler/v0.3.1...profiler/v0.4.0) (2023-10-18)


### Features

* **profiler:** Support configurable debug logging destination ([#8104](https://github.com/googleapis/google-cloud-go/issues/8104)) ([fc3d840](https://github.com/googleapis/google-cloud-go/commit/fc3d84058b8932152408bc3ee0a5584dfe0b0c19))
* **profiler:** Update all direct dependencies ([b340d03](https://github.com/googleapis/google-cloud-go/commit/b340d030f2b52a4ce48846ce63984b28583abde6))


### Bug Fixes

* **profiler:** Migrate to protobuf-go v2 ([#8730](https://github.com/googleapis/google-cloud-go/issues/8730)) ([deeb583](https://github.com/googleapis/google-cloud-go/commit/deeb58308cbbb033e46d478b4dc8766c6689e71e)), refs [#8585](https://github.com/googleapis/google-cloud-go/issues/8585)
* **profiler:** REST query UpdateMask bug ([df52820](https://github.com/googleapis/google-cloud-go/commit/df52820b0e7721954809a8aa8700b93c5662dc9b))
* **profiler:** Update golang.org/x/net to v0.17.0 ([174da47](https://github.com/googleapis/google-cloud-go/commit/174da47254fefb12921bbfc65b7829a453af6f5d))
* **profiler:** Update grpc to v1.55.0 ([1147ce0](https://github.com/googleapis/google-cloud-go/commit/1147ce02a990276ca4f8ab7a1ab65c14da4450ef))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punya punya

@noahdietz noahdietz

Labels
api: cloudprofiler Issues related to the Cloud Profiler API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release profiler 0.4.0 googleapis/google-cloud-go
5 participants
@punya @noahdietz @trevorwng @cc4i and others