fix(spanner): switch order of ListBackupOperations() filter conjuncts #7746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the metadata is of the desired type in the left-hand side of the `ListBackupOperations()` filter AND expression, before looking at its value. This appears to be a recent change in behavior for the production service, which previously accepted the original ordering, but now would say: "INVALID_ARGUMENT: Invalid ListBackupOperations request." Also change the filter subexpressions to be exact matches, rather than just "contains", so as to make the filtering more precise. Finally, take this opportunity to log the name of running sample, which makes it easier to delineate the RPC log. Fixes googleapis#7741.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7746 +/- ##
==========================================
- Coverage 95.28% 95.28% -0.01%
==========================================
Files 1257 1257
Lines 114109 114111 +2
==========================================
Hits 108728 108728
- Misses 5381 5383 +2
Continue to review full report at Codecov.
|
coryan
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the metadata is of the desired type in the left-hand
side of the
ListBackupOperations()filter AND expression, beforelooking at its value.
This appears to be a recent change in behavior for the production
service, which previously accepted the original ordering, but now
would say: "INVALID_ARGUMENT: Invalid ListBackupOperations request."
Also change the filter subexpressions to be exact matches, rather
than just "contains", so as to make the filtering more precise.
Finally, take this opportunity to log the name of running sample,
which makes it easier to delineate the RPC log.
Fixes #7741.
This change is