Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(macos): install ccache when needed #6698

Merged
merged 2 commits into from
Jun 5, 2021

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Jun 4, 2021

This change is Reviewable

@devjgm devjgm requested a review from a team as a code owner June 4, 2021 20:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2021
@devjgm devjgm force-pushed the macos-missing-brews branch from 246358c to afb74ff Compare June 4, 2021 21:00
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 246358c14efc3e740179a25e5db49eead0aa1358

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: afb74ff2a45bd816e7983e529a540db7ae7b8d84

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #6698 (c7c1247) into main (2211aeb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6698   +/-   ##
=======================================
  Coverage   95.69%   95.69%           
=======================================
  Files        1215     1215           
  Lines      112632   112632           
=======================================
  Hits       107784   107784           
  Misses       4848     4848           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2211aeb...c7c1247. Read the comment docs.

@devjgm
Copy link
Contributor Author

devjgm commented Jun 4, 2021

Added install of pkg-config also, which vcpkg needs during the quickstart-cmake build

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: c7c12472703d04ca8b9ec528d07ed53c54a1d6af

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@@ -22,6 +22,9 @@ source module /ci/etc/quickstart-config.sh

io::log_h2 "Update or install dependencies"

# vcpkg needs this
brew install pkg-config || pkg-config --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what these idioms mean. If we fail to install pkg-config, we print its version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that this is a bit strange. I'm mostly just following the established pattern that was already here. I think it's written like this because brew install <foo> commonly fails if foo is already installed but a newer version is available. It fails because we're told brew not to update packages (with HOMEBREW_NO_AUTO_UPDATE=1). But in the case of this failure, we want to proceed so we execute the command (that we think is installed) and prints its version. It's similar to || true, except that it will fail the the brew install fails for some other reason and the command actually does not exist.

Anyway, I think we may want to revisit the need for any of these brew commands now that we're running on more modern kokoro mac machines. We may be able to get rid of all of them (or many).

@devjgm devjgm merged commit 4032b07 into googleapis:main Jun 5, 2021
@devjgm devjgm deleted the macos-missing-brews branch June 5, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants