-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(macos): install ccache when needed #6698
Conversation
246358c
to
afb74ff
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6698 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 1215 1215
Lines 112632 112632
=======================================
Hits 107784 107784
Misses 4848 4848 Continue to review full report at Codecov.
|
Added install of |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
@@ -22,6 +22,9 @@ source module /ci/etc/quickstart-config.sh | |||
|
|||
io::log_h2 "Update or install dependencies" | |||
|
|||
# vcpkg needs this | |||
brew install pkg-config || pkg-config --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what these idioms mean. If we fail to install pkg-config
, we print its version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that this is a bit strange. I'm mostly just following the established pattern that was already here. I think it's written like this because brew install <foo>
commonly fails if foo is already installed but a newer version is available. It fails because we're told brew
not to update packages (with HOMEBREW_NO_AUTO_UPDATE=1
). But in the case of this failure, we want to proceed so we execute the command (that we think is installed) and prints its version. It's similar to || true
, except that it will fail the the brew install
fails for some other reason and the command actually does not exist.
Anyway, I think we may want to revisit the need for any of these brew commands now that we're running on more modern kokoro mac machines. We may be able to get rid of all of them (or many).
This change is